Project

General

Profile

Actions

action #132776

closed

coordination #121864: [epic] Split and enhance test modules in migrations

Improve recently created test module setup_sle.pm

Added by JERiveraMoya over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Target version:
Start date:
2023-07-14
Due date:
% Done:

0%

Estimated time:

Description

Motivation

Modify this test module so it will very readable and the user can distinguish well what is the setup without going in depth in the code. setup_sle.pm

sle 15 that is our target for now, due to is where we can use libyui-rest-api and have all the improvements together, refactor + libyui-rest-api. Taking a look to sub setup_sle:

  • Search why we need this (git history?) and write a comment with the answer: assert_script_run "chmod 444 /usr/sbin/packagekitd";
  • This is not needed here, but in the previous module that does the patching: wait_quit_zypper;
  • why to do this again? ensure_serialdev_permissions the console at this point is working fine in openQA ..
  • why we run this for the-system-to-be-migrated enter_cmd "echo 'export Y2DEBUG=1' >> /etc/bash.bashrc.local"; I mean we can increase debug log in the installer for migration and in the system migrated you can open modules with that setting, but at this point I don't find the meaning...
  • we don't need to take into account set_zypp_single_rpmtrans.
  • We need to remove this logic set_var('HDD_SCC_REGISTERED', 1) if get_var('KEEP_REGISTERED'); is unclear why we need this hack, perhaps we can resolve this by schedule, please describe goal of this with example.

Acceptance criteria

AC1: Apply the improvements described above answering all those questions so the test module is very readable

Additional information

Refactored test suite are currently in this job group with names ending on *_split_patch_sle.

Actions #1

Updated by JERiveraMoya over 1 year ago

  • Description updated (diff)
Actions #2

Updated by JERiveraMoya over 1 year ago

  • Description updated (diff)
Actions #3

Updated by JERiveraMoya over 1 year ago

  • Description updated (diff)
Actions #4

Updated by tinawang123 about 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to tinawang123
Actions #5

Updated by tinawang123 about 1 year ago

322046a998 (qmsu 2018-04-24 09:35:12 +0200 44) if (is_sle('12+')) {
a13b2748b4 (JoaquĆ­n Rivera 2020-12-16 08:48:37 +0100 45) quit_packagekit;
8c481cd263 (Jiawei Sun 2018-02-27 16:49:13 +0800 46) }
8c481cd263 (Jiawei Sun 2018-02-27 16:49:13 +0800 47) else {
8c481cd263 (Jiawei Sun 2018-02-27 16:49:13 +0800 48) assert_script_run "chmod 444 /usr/sbin/packagekitd";
8c481cd263 (Jiawei Sun 2018-02-27 16:49:13 +0800 49) }
For assert_script_run "chmod 444 /usr/sbin/packagekitd"; it used for sle11, as we don't need this test, So we can remove this line.

Actions #7

Updated by tinawang123 about 1 year ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF