Project

General

Profile

Actions

action #97112

closed

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #94750: [epic] Support needles from git-cloned or separate repo if casedir points to a git-repo

Support relative needle directories together with tests checked out from git

Added by okurz over 3 years ago. Updated 5 months ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Motivation

See the unexpected current default behaviour in #94735

Acceptance criteria

  • AC1: For tests with CASEDIR pointing to a git repo including tests+needles by default needles from that repo should be used and not a non-git default repo

Suggestions

  • To understand how the current behaviour is it is suggested to trigger tests with CASEDIR=https://github.com/os-autoinst/os-autoinst-distri-example because the example distribution includes needles in the same repo
  • Discussed with mkittler and livdywan. We propose to shift more logic into os-autoinst and implement an additional keyword so that os-autoinst looks up only a fallback needles repo in case needles are not found anywhere else. Also we assume that os-autoinst is easier to change and maintain. The current proposal is to use NEEDLES_DIR=[<keyword>]<dir>, e.g. NEEDLES_DIR=[fallback]my/productdir/needles for a relative fallback directory. The only suggested to be supported keyword should be "fallback" for now.

  • In os-autoinst parse keyword from NEEDLES_DIR

  • If "[fallback]" then try to find needles in all default paths, e.g. subdir of casedir, productdir, etc., only if not found look up in the fallback one

  • Prepare setting fallback in openQA Worker/Engines/isotovideo.pm but do not merge yet

  • Deploy new feature in os-autoinst

  • Wait grace period

  • Deploy openQA feature


Related issues 2 (0 open2 closed)

Copied from openQA Project (public) - action #94735: needles not found in `needles` subdirectory when CASEDIR is a git repositoryResolvedmkittler2021-06-25

Actions
Copied to openQA Project (public) - action #164577: [timeboxed:6h][research] Understand the current behaviour of openQA test distributions including needlesResolvedmkittler2024-07-29

Actions
Actions #1

Updated by okurz over 3 years ago

  • Copied from action #94735: needles not found in `needles` subdirectory when CASEDIR is a git repository added
Actions #2

Updated by okurz 6 months ago

  • Target version changed from future to Ready
Actions #3

Updated by okurz 5 months ago

  • Description updated (diff)
  • Assignee set to okurz

Couldn't agree on an estimate. Decided to create a timeboxed research task first to find out the current situation of tests+needles in one repo vs. tests+needles in separate repos.

Actions #4

Updated by okurz 5 months ago

  • Copied to action #164577: [timeboxed:6h][research] Understand the current behaviour of openQA test distributions including needles added
Actions #5

Updated by okurz 5 months ago

  • Status changed from New to Blocked
Actions #6

Updated by okurz 5 months ago

  • Status changed from Blocked to Resolved

We decided that it's not worth to change the default behaviour and rather ask to specify needles dirs explicitly at best in all cases. The documentation on http://open.qa/docs/ explains that and also mentions examples like CASEDIR=https://github.com/os-autoinst/os-autoinst-distri-example.git NEEDLES_DIR=%%CASEDIR%%/needles. With this relative needle directories are supported

Actions

Also available in: Atom PDF