action #95275
closed[qe-core] Failure in x11_start_program breaks post_fail_hook of following modules
100%
Description
https://openqa.opensuse.org/tests/1831535 shows various failing modules.
usr_sbin_smbd fails in x11_start_program because the expected needle doesn't appear. This sets IN_X11_START_PROGRAM to the full commandline.
The post fail hook then tries to run which get_var("IN_X11_START_PROGRAM"), which due to a bug uses the full commandline and not just the executable itself.
This failure causes the post_fail_hook to abort, which is ok so far.
The issue is that IN_X11_START_PROGRAM stays set, even after the lastgood snapshot is loaded. Thus all post_fail_hook invocations fail early because they all attempt to run the broken which command.
Updated by okurz almost 3 years ago
- Category set to Support
- Assignee set to okurz
- Target version set to Ready
hm, do you really consider this an issue of openQA itself, like in os-autoinst where the general handling of the post_fail_hook is or more likely in os-autoinst-distri-opensuse?
Updated by favogt almost 3 years ago
- Status changed from Feedback to New
hm, do you really consider this an issue of openQA itself, like in os-autoinst where the general handling of the post_fail_hook is or more likely in os-autoinst-distri-opensuse?
Depends. IMO variables should be restored as well when a snapshot is loaded, otherwise the test behaves very differently. That would be os-autoinst's responsibility.
If not, then it would be a bug in os-autoinst-distri-opensuse.
Updated by okurz almost 3 years ago
- Project changed from openQA Project to openQA Tests
- Subject changed from Failure in x11_start_program breaks post_fail_hook of following modules to [qe-core] Failure in x11_start_program breaks post_fail_hook of following modules
- Category changed from Support to Enhancement to existing tests
- Assignee deleted (
okurz) - Target version deleted (
Ready)
I am sure we should not update test specific test variables from os-autoinst side. This needs to by handled by the test distribution code. Hence moving back to test issue tracker, assigning to qe-core as likely owner of "x11_start_program".
Updated by favogt over 2 years ago
- Status changed from New to In Progress
- Assignee set to favogt
Updated by favogt over 2 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
PR got merged.