action #92034
closedQA - coordination #91646: [saga][epic] SUSE Maintenance QA workflows with fully automated testing, approval and release
openQA Project - coordination #89062: [epic] Simplify review for SUSE QAM
Re-enable openqa-investigate options after the black certificate now only shows properly "reviewed" jobs
0%
Description
Motivation¶
openqa-investigate was disabled for SUSE Maintenance job groups on special request due to special workflows however other SUSE QAM reviewers like the idea of openqa-investigate so we would like to bring it back and resolve that special exception
Acceptance criteria¶
- AC1: openqa-investigate jobs are also scheduled for jobs in "Maintenance" job groups on openqa.suse.de
Suggestions¶
- Crosscheck with dzedro and potentially other members of the review group "qam-openqa-review" if that's ok
- Remove the special exception from https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/openqa/server.sls
Updated by mkittler over 3 years ago
SR containing initial discussion: https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/425
There were 3 points:
comments are hiding failures and reviewer does not know if comment is his or from "investigate:retry"
This point has been addressed by the mentioned change regarding the certificate icon.
MM tests are not restarted properly …
When I remember correctly, I've changed it to exclude tests with dependencies completely. So this shouldn't be an issue anymore (although a real solution for this would of course be better).
restarted jobs are renamed, thus don't belong to the same group as original and bot does still see the failed job and auto approve of RR is blocked https://openqa.suse.de/tests/5251199#comments https://openqa.suse.de/tests/5251564#comments https://openqa.suse.de/tests/5251780#comments
Not sure about this one. It doesn't seem like openqa-investigate doesn't make the problem worse - it just doesn't help for approving some PRs automatically.
Draft SR for enabling this: https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/484
Updated by okurz over 3 years ago
Draft SR for enabling this: https://gitlab.suse.de/openqa/salt-states-openqa/-/merge_requests/484
merged. I assume after deployment we still need to restart the instance. I restarted the webUI on osd with systemctl restart openqa-webui and verified that everything looks normal. I suggest you write a message, e.g. in #testing and call this done
Updated by okurz over 3 years ago
- Status changed from In Progress to Resolved
Posted in https://chat.suse.de/channel/testing?msg=d88Xbgym4W8YmPqDW . Following https://openqa.suse.de/tests?match=:investigate: we can see again investigation jobs for Maintenance jobs, e.g. https://openqa.suse.de/tests/5934726 so all good.