Project

General

Profile

Actions
Copy link

action #91491

closed

potential performance regression, failures in os-autoinst t/18-qemu-options.t

Added by okurz over 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
okurz
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2021-04-21
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://github.com/os-autoinst/os-autoinst/pull/1652/checks?check_run_id=2399230336#step:3:539 fails in an unrelated PR with

6:     #   Failed test 'execution time of isotovideo (24.5780038833618 s) within reasonable limits'
6:     #   at ./18-qemu-options.t line 87.
6:     #     '24.5780038833618'
6:     #         <
6:     #     '24'
6:     # Looks like you failed 1 test of 16.
6: 
6: #   Failed test 'qemu_append_option'
6: #   at ./18-qemu-options.t line 110.

24s is long enough. We should crosscheck the current performance.

Expected result

  • 18-qemu-options.t should be able to execute well below 24s in general

Suggestions

  • Run os-autoinst t/18-qemu-options.t in a consisten environment multiple times and derive if there is a performance regression
  • Try to identify which part takes longer now
Actions
Copy link
 #1

Updated by okurz over 3 years ago

  • Target version changed from Ready to future
Actions
Copy link
 #2

Updated by livdywan over 2 years ago

If I never see this fail locally or in CI does it mean it's resolved?

Actions
Copy link
 #3

Updated by okurz over 2 years ago

  • Status changed from Workable to Resolved
  • Assignee set to okurz
  • Target version changed from future to Ready

yes, I think so. I ran runs=500 count_fail_ratio prove -I. t/18-qemu-options.t without problems and the runtime being in the range of 4-6s so all good.

Actions
Copy link

Also available in: Atom PDF