Project

General

Profile

Actions

action #77929

closed

UI build bar alignment broken on index page

Added by okurz over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2020-11-15
Due date:
% Done:

0%

Estimated time:

Description

Observation

See attached screenshot showing how build bars are not properly aligned on the right hand side and also exceed the visible space while there is free space unused. The "free space unused" is to ensure that all entries can be shown and the longest entry takes that space (not shown in screenshot).

Acceptance criteria

  • AC1: The right-hand side of all build bars are aligned
  • AC2: No obvious wasted screen space while keeping readability

Suggestions

  • Look into the history of the pages where we tried to fix similar problems already
  • Check for any obvious regressions
  • Try to fix the right-hand side of all build bars
  • Crosscheck that no other detrimental changes are introduced by your changes.

Files

example of unalignment.png (41 KB) example of unalignment.png ilausuch, 2020-11-16 13:43
Actions #1

Updated by mkittler over 3 years ago

  • Status changed from Workable to New

There's no screenshot attached.

Actions #2

Updated by okurz over 3 years ago

  • Status changed from New to Workable

Created a new screenshot that shows the longest entry of the page along with the build bar next to Aarch64 to exceed the visible space along with a horizontal scroll bar.

Actions #3

Updated by ilausuch over 3 years ago

The example is missing. I provide a new one and working on this

Actions #4

Updated by okurz over 3 years ago

  • Target version changed from future to Ready

huh, again my screenshot isn't there? strange :D

Keep in mind that the target version is "future" so this ticket wasn't actually on our backlog. But ok, let's do it as an exception :)

Can you please set a due that you find reasonable as an estimate how long it should take until we have e.g. an according PR merged?

Actions #6

Updated by okurz over 3 years ago

that's not a link to the PR :D

Actions #7

Updated by ilausuch over 3 years ago

  • Status changed from In Progress to Feedback

I put this in feedback because in my development environment I don't have enough build on the index page to test this. If someone could test it will be nice.

Actions #8

Updated by mkittler over 3 years ago

For feedback, see https://github.com/os-autoinst/openQA/pull/3563#issuecomment-729631950 - but I think is is good enough. Note that it generally not a problem to import test data into your development environment (see https://github.com/Martchus/openQA-helper#create-postgresql-user-maybe-import-some-data).

Actions #9

Updated by ilausuch over 3 years ago

  • Status changed from Feedback to Resolved

The PR is merged

Actions #10

Updated by okurz over 3 years ago

  • Status changed from Resolved to Feedback

ilausuch wrote:

The PR is merged

yes, but please Please aware about our https://progress.opensuse.org/projects/qa/wiki#Definition-of-DONE
Especially issues we can not validate with self-tests within the source repo we should await verification on production instances. As this ticket comes from me I would most likely remember that we had that ticket in case my originally reported problem would not yet be fixed but especially for outside reporters we should give the reporter a chance to give the final approval if the issue was fixed according to that person's requirements or not.
At best just tomorrow on o3 we can check if the issue is gone.

Actions #11

Updated by ilausuch over 3 years ago

  • Status changed from Feedback to Resolved

I checked that yes, this solves the problem in production. I put the status to resolved

Actions

Also available in: Atom PDF