QA » openQA Project » openQA Tests

1. PCW log into it's internal DB that there 4 entities exists
2. Pavel Dostál delete them manually
3. There was not correct handling of situation that someone outside PCW will delete them so it start throwing exceptions and constantly trying to delete them 🙂

https://github.com/cfconrad/pcw/pull/91 - just to fire fight the problem .
things needs to be done :

• cover this function with tests
• cover same scenario for Azure and GCE

unfortunately first attempt to fix issue failed ( spam remains ) . here is second one
https://github.com/cfconrad/pcw/pull/93

Looks like code ( at least for EC2 ) not expecting situation that entity might disappear after been written down to our DB

The code which handle such situation is in ocw.lib.db.sync_csp_to_local_db().
The code works like

• Set all db entries for such provider/namespace to active=false
• Get all instance from provider
• Set only gotten db-entries to active=true where such instance was found.

I would say that the error appear, cause we do not handle exceptions during deletion correctly in ocw.lib.db.delete_instance() https://github.com/cfconrad/pcw/blob/13c33393882e898089daa6ed678e29033c8f07a6/ocw/lib/db.py#L236 and so we do not update the db.

I wonder why this error doesn't heal out on the next sync!!

And that situation cannot be avoided with our current design (and I do not have a design in my mind, where it could :)
Because we always get this race, that a instance can be deleted, just before we press the delete button.