Project

General

Profile

Actions

action #72199

open

check and reduce runtime of t/44-scripts.t

Added by okurz about 4 years ago. Updated about 4 years ago.

Status:
Workable
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://app.circleci.com/pipelines/github/os-autoinst/openQA/4393/workflows/73728ebb-2783-487d-bf09-79f3ee2270ef/jobs/42264 shows

[07:25:28] t/44-scripts.t ............................................ 16/? Bailout called.  Further testing stopped:  test exceeds runtime limit of '120' seconds
FAILED--Further testing stopped: test exceeds runtime limit of '120' seconds

I could reproduce the problem locally, e.g. from lord.arch:

t/44-scripts.t .. 
ok 1 - Calling 'client --help' returns exit code 0
ok 2 - Calling 'create_admin --help' returns exit code 0
ok 3 - Calling 'dump_templates --help' returns exit code 0
ok 4 - Calling 'initdb --help' returns exit code 0
ok 5 - Calling 'load_templates --help' returns exit code 0
ok 6 - Calling 'modify_needle --help' returns exit code 0
ok 7 - Calling 'openqa --help' returns exit code 0
ok 8 - Calling 'openqa-cli --help' returns exit code 0
ok 9 - Calling 'openqa-clone-job --help' returns exit code 0
ok 10 - Calling 'openqa-label-all --help' returns exit code 0
ok 11 - Calling 'openqa-livehandler --help' returns exit code 0
ok 12 - Calling 'openqa-scheduler --help' returns exit code 0
ok 13 - Calling 'openqa-validate-yaml --help' returns exit code 0
ok 14 - Calling 'openqa-websockets --help' returns exit code 0
ok 15 - Calling 'openqa-workercache --help' returns exit code 0
Bailout called.  Further testing stopped:  test exceeds runtime limit of '20' seconds
Bail out!  test exceeds runtime limit of '20' seconds
FAILED--Further testing stopped: test exceeds runtime limit of '20' seconds
## count_fail_ratio: Run: 5. Fails: 5. Fail ratio 100%

Prepared https://github.com/os-autoinst/openQA/pull/3435 to cover this for now with higher timeout. In general it is unfortunate that our scripts take that long already to just show a "--help" screen. This is something that could be improved.

Acceptance criteria

  • AC1: The test runtime in t/44-scripts.t is significantly lower than the current value of 60s

Suggestions

  • Run t/44-scripts.t locally
  • Check if runtime is long or not in your environment. If needed compare different environments.
  • Reproduce the long runtime and identify which individual scripts take how long, e.g. run prove -v -l t/44-scripts.t | ts
  • Either optimize individual cases that take long or indentify why the overall runtime might be long.

Related issues 1 (0 open1 closed)

Copied from openQA Project (public) - action #72127: check and/or reduce runtime of t/44-scripts.tResolvedokurz2020-09-30

Actions
Actions

Also available in: Atom PDF