Project

General

Profile

Actions

action #70564

closed

[y] Add CI check to not allow characters of the kind ©

Added by JERiveraMoya over 3 years ago. Updated over 3 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
Infrastructure
Target version:
Start date:
2020-08-26
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

We would like to add a check to the CI to avoid characters like for example ©
In file headers Always use (C) instead of (©).

Actions #1

Updated by riafarov over 3 years ago

  • Target version changed from SLE 15 SP3 to future

Technically this is wrong statement about copyright, https://www.compart.com/en/unicode/U+00A9 and it's not only unicode, but even utf-8, not utf-16. So I don't see any good reason to do In file headers Always use (C) instead of (©)., but validate that there no non-unicode, or even no non-utf-8 sybmols, that what we could definitely do.

file -bi %filename% can be used to validate charset.

https://github.com/os-autoinst/os-autoinst-distri-opensuse/commit/395183a8d19e5200e2760e9f3b9c6877b60792e7 can be used to test the way we detect not allowed symbols.

Actions #2

Updated by JERiveraMoya over 3 years ago

  • Subject changed from [y] Unicode is not allowed in the content of the test files to [y] Add CI check to not allow characters of the kind ©
  • Description updated (diff)
Actions #3

Updated by JERiveraMoya over 3 years ago

  • Status changed from New to Rejected

Rejected as the goal was just to fix to one character or the other and reduce ambiguity. So we can include it in #70561.

Actions

Also available in: Atom PDF