Actions
action #69586
closed[y] Refactor 'validate_addon_repos' and 'validate_mirror_repos' test modules
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
QA (public, currently private due to #173521) - future
Start date:
2020-08-04
Due date:
2020-08-25
% Done:
0%
Estimated time:
8.00 h
Difficulty:
Description
Motivation¶
parse_repo_data
function was introduced in lib/repo_tools.pm
, which allows to parse the information about repository and provides access to it. Though there is the validate_repo_enablement
function which performs the validation, but it's a little bit limited (e.g. all the values are hard-coded, no way to verify only specific values). So it was decided to remove the validate_repo_enablement
and replace it with parse_repo_data
.
The validate_repo_enablement
is used only in 'validate_addon_repos' and 'validate_mirror_repos' test modules, currently (please, double-check this).
Not to mix openQA variables and test data we can do following:
- Allow expansion of the variables in the test data, like %VERSION% (see https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/master/lib/scheduler.pm#L85 ) We should also add unit tests for testing this functionality
- Define everything as openQA variables
Acceptance criteria¶
validate_repo_enablement
is replaced withparse_repo_data
function in all test modules where it is used.
Updated by riafarov over 4 years ago
- Description updated (diff)
- Status changed from New to Workable
- Target version set to future
- Estimated time set to 8.00 h
Updated by riafarov over 4 years ago
- Status changed from Workable to In Progress
Updated by riafarov over 4 years ago
- Status changed from In Progress to Feedback
Actions