action #66325
closedAdd missing dependencies to os-autoinst spec
0%
Description
In Fedora's os-autoinst spec file, we add several dependencies that we feel should be there, but are missing in the upstream spec. Rather than sending a pull request right away with all of them, I figured I'd file a ticket so we can poke through them and decide which it makes sense to upstream.
I recently moved them to special macros to make it easier to compare downstream and upstream. Here's the current set, with comments:
%define build_requires_additional perl(ExtUtils::MakeMaker) perl(ExtUtils::Embed)
ExtUtils::MakeMaker is explicitly imported in ppmclibs/Makefile.PL, and listed in cpanfile
, but not in the packaged RPM spec. ExtUtils::Embed is used in configure.ac to determine PERL_CFLAGS
, and the RPM spec does run autoreconf -i
in %prep, so it seems like this must be required.
%define requires_additional perl(base) perl(Carp) perl(Cwd) perl(English) perl(Errno) perl(Fcntl) perl(File::Temp) perl(integer) perl(Mojo::JSON) perl(Mojo::Log) perl(POSIX) perl(Scalar::Util) perl(Socket) perl(strict) perl(Time::HiRes) perl(warnings)
these are mostly things one of our perl team added to the spec recently. I figure a lot of them are stuff that currently comes baked into perl itself or the core libs, but having an explicit dependency isn't a bad thing in case something gets broken out into a separate package or whatever. Note there may be a "perl(base)" vs. "perl-base" thing here (we don't have a 'perl-base' package).
%define test_requires_additional perl(FindBin) perl(Test::Mojo) perl(Test::More) /usr/bin/qemu-system-i386
qemu-system-i386 we have because we can run the fullstack and qemu-options tests in the Fedora buildsystem, whereas SUSE can't. Perhaps this would be a candidate for conditionalizing? We could have a %qemu_requires
or something which is defined differently on SUSE and Fedora, but the main %test_requires
definition could be the same, for ease of comparison.
FindBin is explicitly imported by several tests. Test::Mojo is imported by t/07-commands.t. Test::More is explicitly imported by lots of tests.