Actions
action #57776
closed"log_fatal" should mention calling method, not the log message handler itself
Start date:
2019-10-08
Due date:
% Done:
100%
Estimated time:
Description
Observation¶
https://openqa.opensuse.org/tests/1050658# is incomplete with a message "Gru job failed
Reason: Download of http://download.opensuse.org/repositories/KDE:/Medias/images/iso/Argon.x86_64-15.1-Build2.106.iso to /var/lib/openqa/share/factory/iso/Argon.x86_64-15.1-Build2.106.iso failed! Deleting files. at /usr/share/openqa/script/../lib/OpenQA/Utils.pm line 280." while this itself is a problem the location "lib/OpenQA/Utils.pm line 280." is not really helpful as this is just within the "log_fatal" call.
Suggestion¶
Use something like (caller(1))[3] to reference the calling method, not the called method.
Updated by okurz about 5 years ago
- Related to action #57782: retrigger of job with failed gru download task ends up incomplete with 404 on asset, does not retry download added
Updated by tinita about 5 years ago
- Status changed from New to In Progress
- Assignee set to tinita
- Target version set to Current Sprint
I think we can just use croak instead of die in OpenQA::Utils::log_fatal
Updated by tinita about 5 years ago
Updated by tinita about 5 years ago
- Status changed from In Progress to Feedback
- % Done changed from 0 to 100
Updated by tinita about 5 years ago
PR https://github.com/os-autoinst/openQA/pull/2438 was merged
Actions