action #57776

"log_fatal" should mention calling method, not the log message handler itself

Added by okurz 5 months ago. Updated 4 months ago.

Status:ResolvedStart date:08/10/2019
Priority:NormalDue date:
Assignee:tinita% Done:

100%

Category:Feature requests
Target version:Current Sprint
Difficulty:
Duration:

Description

Observation

https://openqa.opensuse.org/tests/1050658# is incomplete with a message "Gru job failed
Reason: Download of http://download.opensuse.org/repositories/KDE:/Medias/images/iso/Argon.x86_64-15.1-Build2.106.iso to /var/lib/openqa/share/factory/iso/Argon.x86_64-15.1-Build2.106.iso failed! Deleting files. at /usr/share/openqa/script/../lib/OpenQA/Utils.pm line 280." while this itself is a problem the location "lib/OpenQA/Utils.pm line 280." is not really helpful as this is just within the "log_fatal" call.

Suggestion

Use something like (caller(1))[3] to reference the calling method, not the called method.


Related issues

Related to openQA Project - action #57782: retrigger of job with failed gru download task ends up in... In Progress 08/10/2019

History

#1 Updated by okurz 5 months ago

  • Related to action #57782: retrigger of job with failed gru download task ends up incomplete with 404 on asset, does not retry download added

#2 Updated by tinita 4 months ago

  • Status changed from New to In Progress
  • Assignee set to tinita
  • Target version set to Current Sprint

I think we can just use croak instead of die in OpenQA::Utils::log_fatal

#4 Updated by tinita 4 months ago

  • Status changed from In Progress to Feedback
  • % Done changed from 0 to 100

#6 Updated by tinita 4 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF