Project

General

Profile

action #49883

OpenQA web ui choose wrong port for websocket if running on non-default port

Added by marmarek about 2 years ago. Updated 12 months ago.

Status:
New
Priority:
Low
Assignee:
-
Category:
Feature requests
Target version:
Start date:
2019-04-02
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Web UI tries to guess whether it's running behind apache (with mod_proxy) or not based on using standard port or not. In case it guess wrong, there is no option to override it.
If I run it (behind apache) on port 81, it tries to connect to livehandler on port 83, which is wrong.
Additionally, even if it runs on port 80 or 443 but specified in URL explicitly, it also tries to use wrong port:

https://github.com/os-autoinst/openQA/blob/master/assets/javascripts/openqa.js#L150-L157

    if (port !== 80 || port !== 443) {
        // if not using default ports we assume we're not accessing the web UI via Apache/NGINX
        // reverse proxy
        // -> so if not specified otherwise, we're further assuming a connection to the livehandler
        //    daemon which is supposed to run under the <web UI port> + 2
        port += servicePortDelta ? servicePortDelta : 2;
    }
    port = ':' + port;
  1. "port !== 80 || port !== 443" is always true
  2. There is no way to override this check. Maybe better inverse the condition - assume direct connection if port is default direct port (9526?)?

History

#1 Updated by okurz almost 2 years ago

  • Category set to Feature requests

#2 Updated by okurz 12 months ago

  • Priority changed from Normal to Low
  • Target version set to future

Also available in: Atom PDF