Project

General

Profile

action #44597

Synchronize perlcritic checks between openQA and os-autoinst

Added by kraih over 1 year ago. Updated over 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
2018-11-30
Due date:
% Done:

90%

Estimated time:
Difficulty:
Duration:

Description

Both projects should follow the same rules to ensure a consistent coding style. For example openQA encourages return undef;, while os-autoinst discourages it (for no good reason). To make sure we follow current Perl community best practices i propose that we start using Perl::Critic::Freenode, and share the same .perlcriticrc in both projects. Perl::Critic::Freenode is a collection of rules that has been collected by the members of the #perl IRC channel on Freenode, over a long period of time. The collection is based on what problems have been brought up the most on #perl and what rules bigger Perl projects that are known for good code quality follow themselves.

History

#1 Updated by kraih over 1 year ago

The openQA side should be mostly done: https://github.com/os-autoinst/openQA/pull/1902. Still working on os-autoinst, which is a little more tricky.

#2 Updated by kraih over 1 year ago

  • % Done changed from 0 to 50

#3 Updated by mkittler over 1 year ago

  • Target version set to Current Sprint

#4 Updated by mkittler over 1 year ago

What is still missing? Are you still working on this?

#5 Updated by kraih over 1 year ago

  • Status changed from In Progress to Closed

There is still the upstream TODO. But that's not very important, so i guess we can consider this done.

#6 Updated by kraih over 1 year ago

  • Status changed from Closed to Resolved
  • % Done changed from 50 to 90

Also available in: Atom PDF