action #44597
closedSynchronize perlcritic checks between openQA and os-autoinst
90%
Description
Both projects should follow the same rules to ensure a consistent coding style. For example openQA encourages return undef;
, while os-autoinst discourages it (for no good reason). To make sure we follow current Perl community best practices i propose that we start using Perl::Critic::Freenode
, and share the same .perlcriticrc
in both projects. Perl::Critic::Freenode
is a collection of rules that has been collected by the members of the #perl
IRC channel on Freenode, over a long period of time. The collection is based on what problems have been brought up the most on #perl
and what rules bigger Perl projects that are known for good code quality follow themselves.
Updated by kraih almost 6 years ago
The openQA side should be mostly done: https://github.com/os-autoinst/openQA/pull/1902. Still working on os-autoinst, which is a little more tricky.
Updated by mkittler almost 6 years ago
What is still missing? Are you still working on this?
Updated by kraih almost 6 years ago
- Status changed from In Progress to Closed
There is still the upstream TODO. But that's not very important, so i guess we can consider this done.
Updated by kraih almost 6 years ago
- Status changed from Closed to Resolved
- % Done changed from 50 to 90