Project

General

Profile

Actions
Copy link

action #44435

closed

Strict and warnings

Added by kraih over 5 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
kraih
Category:
-
Target version:
-
Start date:
2018-11-28
Due date:
% Done:

0%

Estimated time:

Description

There are many modules in the openQA project that do not correctly activate strict and warnings. This can hide very obvious bugs, as has been demonstrated by activating strict and warnings in the t/lib modules recently.

Actions
Copy link
 #1

Updated by okurz over 5 years ago

good point, isn't there a perl critic warning to ensure we use strict and warnings?

Actions
Copy link
 #2

Updated by kraih over 5 years ago

You'd think so, right? I have no idea how perlcritic is used in openQA development yet though. Does it run automated somewhere?

Actions
Copy link
 #3

Updated by okurz over 5 years ago

Let's hope it still is run automatically: https://github.com/os-autoinst/openQA/blob/master/Makefile#L85

We just discovered yesterday in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6294#pullrequestreview-178656533 that the perlcritic checks were actually not run for our main test distribution.

Actions
Copy link
 #4

Updated by okurz over 5 years ago

yes, still triggered automatically, see https://travis-ci.org/os-autoinst/openQA/jobs/460840984#L626 from your own PR's tests.

Actions
Copy link
 #5

Updated by kraih over 5 years ago

This should be resolved now: https://github.com/os-autoinst/openQA/pull/1897. I've also introduced Perl::Critic::Freenode, which should make sure all modules contain use warnings;: https://github.com/os-autoinst/openQA/pull/1902.

Actions
Copy link
 #6

Updated by kraih over 5 years ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF