action #42089
closedReduce debug impact of needle matching
Description
We added a lot of debug output to find problems in the needle matching. By now I'm convinced there is nothing more we can do, so
the stopwatch output does not help anyone - nor do these MATCH lines.
I suggest to reduce the debug output of an assert_screen to be one line per run (there is still some value to see what went on).
So either one of:
- 'no change'
- 'no match, best needle firefox-201702 (0.3)'
Also the WARNING: check_asserted_screen took 9.12 seconds - make your needles more specific should stay, but the impact of it
should also be reduced to e.g. only include the number of needles involved.
Updated by mkittler about 6 years ago
- Status changed from New to Feedback
Most of the stopwatch-related debug lines could be disable by simply setting a variable to 0 because the debug output is already printed conditionally.
Would that be sufficient or should I really get rid of all the lines? Keeping them would have the advantage that we can easily enable the debug output again. For the warning we need the stopwatch anyways.
Maybe make it even configurable (eg. $watch->{debug} = $bmwqemu::vars{ENABLE_STOPWATCH_LOGGIGN} // 0;)?
Updated by coolo about 6 years ago
I don't think we need to have it configurable at this point. Just disable the watch debug
Updated by coolo about 6 years ago
And please clone a firefox test on staging instance - those are always too slow to match :)
So we can see how it looks
Updated by mkittler about 6 years ago
- Status changed from Feedback to In Progress
Updated by mkittler about 6 years ago
- Status changed from In Progress to Resolved
PR is merged (set the ticket back to workable if it is still to verbose)
Updated by coolo about 6 years ago
- Target version changed from Current Sprint to Done
btw: I really like the current logs