action #41543
closedparallel_failed jobs miss t_finished
Description
A job that is not active should get a t_finished. This is easier in all kind of sortings.
openqa=> select distinct state,result from jobs where result!='none' and t_finished is null;
state | result
----------------+--------------------
user_cancelled | parallel_restarted
skipped | parallel_restarted
user_cancelled | parallel_failed
There might be multiple places where we set the result without a t_finished
Updated by coolo over 5 years ago
- Related to action #41483: [tools] medium that should belong to job group was deleted after just 2 minutes making our SLE15 tests in build 47.1 useless ... and more added
Updated by mkittler over 5 years ago
- Status changed from New to In Progress
- Assignee set to mkittler
The problem is that user_cancelled and skipped are no valid job states and hence also no final job states. So those jobs never got a final state assigned and hence also no t_finished. (user_cancelled and skipped are actually results.)
So assigning those results as a state needs to be fixed.
There might be multiple places where we set the result without a t_finished
That is not a problem as long as a valid final state is assigned at some point.
Maybe it makes also sense to improve the validation.
Updated by mkittler over 5 years ago
Updated by mkittler over 5 years ago
I don't know where the jobs with status user_cancelled come from. But those jobs on OSD are quite old (1) and likely the bug which caused these has already been fixed. I tested the database migration to fix the wrong states locally with OSD data. The query from the ticket description yields no results after that and t_finished is not altered for jobs where it is already set.
(1)
select t_created from jobs where state = 'user_cancelled' order by t_created desc;
t_created
---------------------
2016-09-19 21:20:03
2016-09-19 17:32:18
2016-09-19 17:32:18
2016-09-15 22:40:12
2016-09-15 10:00:59
Updated by coolo over 5 years ago
- Status changed from In Progress to Resolved
- Target version changed from Current Sprint to Done
merged