action #31045

Invalid URL gives 500 - should give 404

Added by coolo about 2 years ago. Updated almost 2 years ago.

Status:ResolvedStart date:30/01/2018
Priority:LowDue date:
Assignee:mitiao% Done:

0%

Category:Concrete Bugs
Target version:Done
Difficulty:
Duration:

Description

Someone tried to be clever and guess URLs, but:

/api/v1/assets/iso results in

invalid input syntax for integer: "iso" [for Statement "SELECT me.id, me.type, me.name, me.size, me.checksum, me.last_use_job_id, me.fixed, me.t_created, me.t_updated FROM assets me WHERE ( id = ? )" with ParamValues: 1='iso'] at /usr/share/openqa/script/../lib/OpenQA/WebAPI/Controller/API/V1/Asset.pm line 62

The routes need to only match integers. Entrance level issue IMO

History

#1 Updated by mitiao about 2 years ago

  • Assignee set to mitiao

#2 Updated by mitiao about 2 years ago

  • Status changed from New to In Progress
  • Target version changed from Ready to Current Sprint

#4 Updated by mitiao about 2 years ago

  • Status changed from In Progress to Resolved

PR merged

#5 Updated by szarate almost 2 years ago

  • Target version changed from Current Sprint to Done

Also available in: Atom PDF