don't set mail adress for system user
The system user in openqa has a mail address firstname.lastname@example.org set. That results in a rather ugly gravatar that cannot be changed as the address goes to /dev/null:
The ttm user on the other hand does not have a mail address which results in a better icon (maybe openqa could avoid asking gravatar in the first place for those). So I'd suggest to unset the mail address for the system user too.
#6 Updated by coolo over 1 year ago
that's just a typo of lnussel:
dbicdh/_common/upgrade/49-50/01-add-system-user.pl: email => 'email@example.com', dbicdh/_common/upgrade/50-51/01-add-system-user.pl: email => 'firstname.lastname@example.org', lib/OpenQA/Schema.pm: email => 'email@example.com', t/06-users.t: is($system_user->email, 'firstname.lastname@example.org', 'system user`s email uses open.qa domain');
#7 Updated by okurz over 1 year ago
- Description updated (diff)
It even was a double "typo" mistake :/
ok, I called
update users set email = null where username = 'system'; for the database on o3 and the icon e.g. in https://openqa.opensuse.org/tests/576994#comments looks the same now for both ttm and system. Now the icons are not unique anymore. I am not convinced this is better. I guess we could create unique email adresses and register them properly with gravatar and select an appropriate icon for each. I like the github https://uxdesign.cc/design-avatars-that-make-sense-and-be-more-inclusive-in-the-process-d4dd6a486ea6 more than the gravatar avatars when one does not provide a custom picture. Or we try to find a nicer looking gravatar pic by playing around with the fake email adress we give to "system". This is what I did now with the SQL command
update users set email = 'email@example.com' where username = 'system'; which brings us which I think looks nicer by chance. If you like it as well then I can provide a PR to change the email adress field in source code. I doubt anyone would write an email to "firstname.lastname@example.org" who would also not by mistake write to "email@example.com". However, what about changing the type of the non-custom icons to something different, e.g. "identicon"? This would give us for "firstname.lastname@example.org" or for "email@example.com"
#12 Updated by coolo over 1 year ago
Just as it was my decision to use wavatar for OBS: https://github.com/openSUSE/open-build-service/commit/c2e2304b655bfc6bc592b88d988027c6b16beccb
No progress without mistakes :)