action #30124
closeddon't set mail adress for system user
Description
The system user in openqa has a mail address noemail@open.qa set. That results in a rather ugly gravatar that cannot be changed as the address goes to /dev/null:
https://openqa.opensuse.org/tests/576994#comments
The ttm user on the other hand does not have a mail address which results in a better icon (maybe openqa could avoid asking gravatar in the first place for those). So I'd suggest to unset the mail address for the system user too.
Updated by coolo over 6 years ago
- Category set to Feature requests
- Target version set to Ready
- Difficulty set to easy
Updated by coolo about 6 years ago
- Target version changed from Ready to Current Sprint
Updated by okurz about 6 years ago
- Status changed from New to In Progress
This email adress nomail@openqa.qa is neither set in openQA source code nor salt pillars nor states. I assume either set locally in config on osd/o3 or manually in the database on at least o3, maybe osd as well. will check.
Updated by coolo about 6 years ago
that's just a typo of lnussel:
dbicdh/_common/upgrade/49-50/01-add-system-user.pl: email => 'noemail@open.qa',
dbicdh/_common/upgrade/50-51/01-add-system-user.pl: email => 'noemail@open.qa',
lib/OpenQA/Schema.pm: email => 'noemail@open.qa',
t/06-users.t: is($system_user->email, 'noemail@open.qa', 'system user`s email uses open.qa domain');
Updated by okurz about 6 years ago
- Description updated (diff)
It even was a double "typo" mistake :/
ok, I called update users set email = null where username = 'system'; for the database on o3 and the icon e.g. in https://openqa.opensuse.org/tests/576994#comments looks the same now for both ttm and system. Now the icons are not unique anymore. I am not convinced this is better. I guess we could create unique email adresses and register them properly with gravatar and select an appropriate icon for each. I like the github https://uxdesign.cc/design-avatars-that-make-sense-and-be-more-inclusive-in-the-process-d4dd6a486ea6 more than the gravatar avatars when one does not provide a custom picture. Or we try to find a nicer looking gravatar pic by playing around with the fake email adress we give to "system". This is what I did now with the SQL command update users set email = 'system@open.qa' where username = 'system'; which brings us 
Updated by coolo about 6 years ago
We can't change the gravatar for email adresses we can't receive email for. So leave it with system if you like that better.
Updated by coolo about 6 years ago
Build service uses a different default which results in 
Both look a lot like system users :)
Updated by coolo about 6 years ago
So that sounds like an easy fix: stick to noemail@ but use wavatar instead of monsterid. All monsters on openqa.suse.de look silly, while the wavatars look reasonable.
Updated by okurz about 6 years ago
- Status changed from In Progress to Feedback
Well, as it was your decision to come up with monsters I do not see a problem to change that ;) -> https://github.com/os-autoinst/openQA/pull/1822
Updated by coolo about 6 years ago
Just as it was my decision to use wavatar for OBS: https://github.com/openSUSE/open-build-service/commit/c2e2304b655bfc6bc592b88d988027c6b16beccb
No progress without mistakes :)
Updated by okurz about 6 years ago
- Status changed from Feedback to Resolved
I meant: As you already commented that you prefer the new way I do not need to ask someone else
Updated by lnussel about 6 years ago
of the three choices identicon looks least childish.
Updated by coolo about 6 years ago
- Target version changed from Current Sprint to Done
Well, seriousness wasn't the goal :)