action #2638


Fix/improve comments in OBS

Added by ancorgs about 10 years ago. Updated almost 10 years ago.

Target version:
Start date:
Due date:
% Done:


Estimated time:
5.00 h


As can be seen in the example comment at href of links is not properly computed when the instance is hosted in https.

Since we need to fix that, it will also be a good opportunity to tackle this:

  <ancor> the good part about using our markup (like req#22) is that OBS takes care of proper rendering :-)
  <coolo> ancor: just that "Request req#236245" looks pretty silly
  <ancor> well, we can always improve the markup a little bit to accept "Request#222 on package #Apache submitted by @whoever".
Actions #1

Updated by ancorgs about 10 years ago

  • Target version set to Staging sprint 10
Actions #2

Updated by coolo about 10 years ago

Much more import atm: still sends one accept comment per package. quite spammy - as accept is always one call per project

Actions #3

Updated by ancorgs almost 10 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 30

Everything fixed in the OBS side (coolo fixed the wrong urls a week ago and I have just improved the markup with Time to improve comments in the osc plugin.

Actions #4

Updated by ancorgs almost 10 years ago

  • % Done changed from 30 to 80

Fixed accept to write just one comment. Quite some time spent in writing tests (that were missing for accept)

Actions #5

Updated by ancorgs almost 10 years ago

  • Status changed from In Progress to Closed
  • Assignee set to ancorgs
  • % Done changed from 80 to 100

Nicer comments for (un)select using the new markup Everything else done (accept comments seems to be working), so closing the issue.


Also available in: Atom PDF