action #2638
closedFix/improve comments in OBS
100%
Description
As can be seen in the example comment at https://build.opensuse.org/project/show/home:ancorgs href of links is not properly computed when the instance is hosted in https.
Since we need to fix that, it will also be a good opportunity to tackle this:
<ancor> the good part about using our markup (like req#22) is that OBS takes care of proper rendering :-)
<coolo> ancor: just that "Request req#236245" looks pretty silly
<ancor> well, we can always improve the markup a little bit to accept "Request#222 on package #Apache submitted by @whoever".
Updated by coolo almost 10 years ago
Much more import atm: https://build.opensuse.org/project/show/openSUSE:Factory:Staging:E still sends one accept comment per package. quite spammy - as accept is always one call per project
Updated by ancorgs almost 10 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 30
Everything fixed in the OBS side (coolo fixed the wrong urls a week ago and I have just improved the markup with https://github.com/openSUSE/open-build-service/pull/707). Time to improve comments in the osc plugin.
Updated by ancorgs almost 10 years ago
- % Done changed from 30 to 80
Fixed accept to write just one comment. Quite some time spent in writing tests (that were missing for accept) https://github.com/openSUSE/osc-plugin-factory/pull/166
Updated by ancorgs almost 10 years ago
- Status changed from In Progress to Closed
- Assignee set to ancorgs
- % Done changed from 80 to 100
Nicer comments for (un)select using the new markup https://github.com/openSUSE/osc-plugin-factory/pull/167 Everything else done (accept comments seems to be working), so closing the issue.