Project

General

Profile

Actions
Copy link

tickets #25300

closed

saltstack: mention fork owner and pending upstream PRs on formulas_update.sh

Added by tampakrap over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
tampakrap
Category:
Configuration management (CM)
Target version:
-
Start date:
2017-09-15
Due date:
% Done:

0%

Estimated time:

Description

The formulas_update.sh script needs a better way to mention:

  • original owner
  • forked owner
  • (bonus points for) pending upstream PRs

This way we can later have a monitoring check that tests if the upstream PRs are all mentioned, so that we can switch back to the original owner's URL

Actions
Copy link
 #1

Updated by tampakrap over 6 years ago

  • Private changed from Yes to No
Actions
Copy link
 #2

Updated by cboltz over 6 years ago

I know it's a boring way, but IMHO comments in formulas_update.sh are the easiest way to handle this.

  • we track the fork owner in the script anyway (owner=...)
  • adding the reason (like a pull request) as a comment is easy
  • when the pull request gets accepted and we can switch to the "official" formula, we need to modify the script - and can cleanup the then-outdated comments while doing so

See https://gitlab.opensuse.org/infra/salt/merge_requests/61 for an example how I'd handle this.

BTW: A monitoring check for upstream PRs sounds slightly ;-) overengineered to me - checking them manually every few months is probably easier and faster than writing a monitoring script ;-)

Actions
Copy link
 #3

Updated by tampakrap over 6 years ago

  • Status changed from New to Closed

fixed by introducing FORMULAS.yaml and bin/get_formulas.py script, see

thanks a lot to cboltz for his strong nerves reviewing my stuff :)

Actions
Copy link

Also available in: Atom PDF