action #2516
closed
better error message on incomplete profile
Added by cboltz almost 10 years ago.
Updated over 9 years ago.
Description
I just had some "fun" with the TSP app and would like to ask for a better error message.
I got:
Something went wrong. Unable to submit.
Requester important information is missing in the user's profile.
It would be very helpful if the error message would say
"Please fill in your $fieldname"
so that I'd know what exactly is missing.
In my case I first tried birthday and passport number (not sure if they are really needed), and then found out the missing mobile phone number (mapped to "phone") was the problem.
BTW: Are really two phone numbers required? Otherwise the check could be "phone" or "other phone" must be filled.
BTW 2: it might be a good idea to change the field names to "Telephone" and "Mobile phone" to be in sync with https://connect.opensuse.org/pg/profile/cboltz
- Category set to Development
- Assignee set to ancorgs
- Target version set to Version 1.1
- Status changed from New to Closed
- % Done changed from 0 to 100
Implemented better error reporting. Now the list of missing fields is displayed
https://github.com/openSUSE/travel-support-program/commit/5c4bb0a3ebbf55903fe32922f9cab963e89b719d
Checking "one phone or another" will probably not be implemented right now, but feel free to reopen the issue if you feel it's important enough. Why not? One of the requirements for the development of the application is to remain extremely configurable. Hence, the list of mandatory fields is now a configuration parameter in a config file. Implementing more complex checks would mean more complex config files and there are other priorities right now.
Thanks for the feedback!
- Copied to action #6576: confusing labels: phone / other phone added
Also available in: Atom
PDF