action #20218
closedFail to login into openqa.suse.de
100%
Description
I've seen this with both alice and aherzig - they get a 500 when coming back from openid provider:
[Mon Jul 3 10:56:08 2017] [29750:debug] GET "/response"
[Mon Jul 3 10:56:08 2017] [29750:debug] Routing to controller "OpenQA::WebAPI::Controller::Session" and action "response"
[Mon Jul 3 10:56:08 2017] [29750:error] Not an OpenID message at /usr/share/openqa/script/../lib/OpenQA/WebAPI/Auth/OpenID.pm line 110.
[Mon Jul 3 10:56:08 2017] [29750:debug] Template "exception.production.html.ep" not found
[Mon Jul 3 10:56:08 2017] [29750:debug] Rendering template "exception.html.ep"
[Mon Jul 3 10:56:08 2017] [29750:debug] Rendering template "layouts/error.html.ep"
[Mon Jul 3 10:56:08 2017] [29750:debug] 500 Internal Server Error (0.017428s, 57.379/s)
Updated by EDiGiacinto almost 7 years ago
I randomly faced that error too (also on my local instance). Looks like a problem while getting the message from the OpenID provider and Net::OpenID::Consumer seems to handle it just as "not OpenID data" https://metacpan.org/source/WROG/Net-OpenID-Consumer-1.18/lib/Net/OpenID/Consumer.pm#L428 , sadly from the module i see no way of workarounding it (unless we try to force the minimum_versions of openid providers - but not sure will fix the issue).
Updated by EDiGiacinto almost 7 years ago
PR is merged, but just ensures to not throw 500 error to the user when openID provider returns invalid(?) data, now we display an error message and in such way avoid to let webui-workers die.
From the logs seems the login error still persists, so i'd go further opening a new ticket related to this one investigating the root cause(still unknown) of the login failure.
To me looks like Net::OpenID::Consumer is not capable to parse some messages from the openID provider and bails out, tried to look over alternatives, but there are not up-to-date/well-tested modules on CPAN that does the same (also if i'd give Net::OpenID::Consumer::Lite a shot)
Updated by coolo over 6 years ago
- Status changed from New to Resolved
we have another issue about the last commit, so close this one