Project

General

Profile

action #19526

[tools] Tests incomplete if asset download fails even the first time

Added by nicksinger almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Low
Assignee:
szarate
Category:
Concrete Bugs
Target version:
Milestone 8
Start date:
2017-05-30
Due date:
% Done:

0%

Estimated time:
Difficulty:
Duration:

Description

observation

http://openqa.suse.de/tests/976197 and http://openqa.suse.de/tests/975974 both fail incomplete.

From http://openqa.suse.de/tests/975974/file/autoinst-log.txt:

+++ setup notes +++
start time: 2017-06-01 19:37:08
running on openqaworker2:19 (Linux 4.7.5-2.g02c4d35-default #1 SMP PREEMPT Mon Sep 26 08:11:45 UTC 2016 (02c4d35) x86_64)
Downloading sle-12-SP1-Server-DVD-x86_64-gnome.qcow2 from http://openqa.suse.de/tests/975974/asset/hdd/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 7%
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 8%
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 14%
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 18%
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 24%
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 29%
CACHE: Downloading /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2: 34%
CACHE: Size of /var/lib/openqa/cache/sle-12-SP1-Server-DVD-x86_64-gnome.qcow2 differs, Expected: 5327028224 / Downloaded: 1845575539
+++ worker notes +++
end time: 2017-06-01 19:39:18
result: setup failure: Can't download sle-12-SP1-Server-DVD-x86_64-gnome.qcow2
uploading autoinst-log.txt

## problem

For me this looks like the code aborts and bails out as soon as the expected download size does not match.


## suggestion

* At least try a second time
* Handle download interruptions more solid (e.g. resume temporary failing downloads)
* Some check of what failed exactly (Is file to download maybe EOF? Is network down?)

Related issues

Copied from openQA Project - action #19436: [tools]cache download suddently interrupts within the output of a log messageResolved2017-05-30

History

#1 Updated by nicksinger almost 3 years ago

  • Copied from action #19436: [tools]cache download suddently interrupts within the output of a log message added

#2 Updated by szarate almost 3 years ago

  • Priority changed from High to Normal
  • Target version set to Milestone 8

We need to find a way to make the downloads a bit more reliable... Mojo::UA should be able to handle everything fine... but somehow either the Apache is not providing the whole content or the connection being reset.

A quick PR with a quick fix has been created: https://github.com/os-autoinst/openQA/pull/1359

#3 Updated by szarate almost 3 years ago

  • Status changed from In Progress to Resolved
  • Assignee set to szarate
  • Priority changed from Normal to Low

My bad :)

#4 Updated by szarate almost 3 years ago

  • Status changed from Resolved to In Progress

#5 Updated by szarate almost 3 years ago

  • Status changed from In Progress to Resolved

Setting to resolved, this has been addressed by this commit with it's proper test.

Also available in: Atom PDF