action #19388
closedShow bugrefs/labels/comments and filters in /tests route like /tests/overview and #previous
0%
Description
User story¶
As a test reviewer looking for common issues in tests regardless of the products/versions/job groups I would like to see if comments exists and filter for failed jobs to find unreviewed jobs efficiently.
acceptance criteria¶
- AC1: /tests route shows comments availability on jobs
- AC2: filters are available over /tests route as well
tasks¶
- TODO
further details¶
This should be done without duplicating all code. A side-goal should be to harmonize /tests and /tests/overview more.
Updated by okurz over 7 years ago
- Related to action #16556: Need to display "incomplete" jobs in "Previous results" added
Updated by mkittler over 7 years ago
- Status changed from New to In Progress
- Assignee set to mkittler
Updated by mkittler over 7 years ago
- Related to action #16692: [tools]Refactor controller code for server-side data tables added
Updated by mkittler over 7 years ago
Due to performance, the 'All tests' table should be made server-side before:
Updated by mkittler over 7 years ago
- Status changed from In Progress to Feedback
The commit for this (https://github.com/os-autoinst/openQA/commit/2ad797f60e76177b73a67f664916744e116581c1) has been merged anyways. Let's see whether it works in production.
Updated by okurz over 7 years ago
I think we don't run this yet on production. Also I have a problem with the changes from this PR with my local sqlite database but not on lord.arch. I guess it should be ok for now. Next step: Other icons :-)
Updated by mkittler about 7 years ago
Works on O3 instance (comment icon for 'Build18.49 of opensuse-5.10.90-Krypton-Live.x86_64' is shown).
AC1 only mentions comments, but no bug refs/labels. Showing refs/labels would decrease the performance even further because currently the comments would have to be parsed for this.
So I'll continue with implementing a filter similar to what we already on the test overview page. Let's see how much I can avoid duplicating the code.
Updated by mkittler about 7 years ago
- Status changed from Feedback to In Progress
Updated by mkittler about 7 years ago
PR for filter: https://github.com/os-autoinst/openQA/pull/1464
Updated by okurz about 7 years ago
- Related to action #25814: load job page, e.g. test details, only on demand added
Updated by mkittler about 7 years ago
- Status changed from In Progress to Resolved
Filter and comment icons are working on osd.
Updated by okurz about 7 years ago
good work. Can you create a follow-up story about the bugrefs and labels? Using the internal bug database should prevent a significant performance regression.