QA (public) » openQA Project (public)

Motivation¶

In the context of #154180 the question came up if old kvm assets should be cleaned up as part of (osd) production infrastructure or perhaps this could be an upstream openQA feature.

For reference, what we do at the time of this writing:
https://gitlab.suse.de/openqa/salt-states-openqa/-/blob/master/libvirt/cleanup-openqa-assets

 if [[ $(df | grep "/var/lib/libvirt/images" | awk '{print $5}' | sed "s/\%//") -gt 70 ]] ; then
    find /var/lib/libvirt/images/*.qcow2 ! -exec fuser -s "{}" \; -delete 2>/dev/null

Acceptance criteria¶

• AC1: s390x kvm assets are prepared and deleted as part of openQA job scheduling without additional handling

Suggestions¶

• Lookup how the s390x kvm backend works from https://github.com/os-autoinst/os-autoinst/blob/master/backend/svirt.pm
• Confirm if the backend code actually prepares these images and decides where to store them
  • In which case it would make sense to clean them automatically
  • The script in salt cleans "some" files by a pattern, not necessarily the ones created by the backend
  • Can this be fully controlled by os-autoinst or openQA clean-up jobs?
  • This would be a new openQA feature in this case?
• Consider to clean up assets when no longer in use, or even deleted after they have been used, or reuse the same files over and over again to not fill up
• Note this is concerning the libvirt host, meaning different scope to what openQA cleanup usually manages - do we want openQA to care about this case, too?
  • Maybe want a "worker cache" but not on workers
• Keep it simple? Just delete the oldest file?