action #178729
closed
Added by JERiveraMoya about 2 months ago.
Updated about 1 month ago.
Description
Motivation¶
Product cannot be validate with cat /etc/os-release due it doesn't differentiate well between sles and sles sap.
Code to do so is create here:
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/21137/files#diff-e03bcc7e57ae5b5e9c171da22862fca99412be4cf5d8d71cc088fd69c9baa7baR16-R20
record_info("baseproduct", "Validate base product");
select_console 'root-console';
my $prod = script_output 'basename `readlink /etc/products.d/baseproduct ` .prod';
assert_equals(shift, $prod, "Wrong product name in '/etc/products.d/baseproduct");
As this PoC might not move forward without the whole squad effort, we can just start to move pieces of that to our production test coverage, so let's create a test module containing this logic.
Acceptance criteria¶
-
AC1: New test module is created to validate base product for default test suite in Online/Full medium replacing os-release-based one.
-
AC2: Drop from job group the EXCLUDE setting to not run the os-release test module.
- Status changed from Workable to In Progress
- Assignee set to zoecao
PR for this ticket: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/21530
And VRS: https://openqa.suse.de/tests/overview?distri=sle&version=16.0&build=chcao_178729
I changed all of the default and default_unattended testsuites to load this new test module instead of checking with /etc/os-release.
@JERiveraMoya, do we need to change it for the autoyast testsuits?
/data/os-autoinst-distri-opensuse # grep -r 'yam/validate/validate_product'
Binary file .git/index matches
schedule/yam/agama_auto_dolomite_select_installation_device.yaml: - yam/validate/validate_product
schedule/yam/agama_auto_gnome.yaml: - yam/validate/validate_product
schedule/yam/agama_auto_tumbleweed.yaml: - yam/validate/validate_product
schedule/yam/agama_auto_tumbleweed_select_installation_device.yaml: - yam/validate/validate_product
schedule/yam/agama_autoyast_supported_ppc64le.yaml: - yam/validate/validate_product
schedule/yam/agama_autoyast_supported_qemu.yaml: - yam/validate/validate_product
schedule/yam/agama_autoyast_supported_s390x.yaml: - yam/validate/validate_product
zoecao wrote in #note-2:
PR for this ticket: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/21530
And VRS: https://openqa.suse.de/tests/overview?distri=sle&version=16.0&build=chcao_178729
I changed all of the default and default_unattended testsuites to load this new test module instead of checking with /etc/os-release.
@JERiveraMoya, do we need to change it for the autoyast testsuits?
/data/os-autoinst-distri-opensuse # grep -r 'yam/validate/validate_product'
Binary file .git/index matches
schedule/yam/agama_auto_dolomite_select_installation_device.yaml: - yam/validate/validate_product
Please delete that file, it is really old, actually you can clean any "dolomite" stuff you find there.
schedule/yam/agama_auto_gnome.yaml: - yam/validate/validate_product
schedule/yam/agama_auto_tumbleweed.yaml: - yam/validate/validate_product
schedule/yam/agama_auto_tumbleweed_select_installation_device.yaml: - yam/validate/validate_product
please check if in openSUSE when we install Tumbleweed or Leap with Agama we can also use this test module.
schedule/yam/agama_autoyast_supported_ppc64le.yaml: - yam/validate/validate_product
schedule/yam/agama_autoyast_supported_qemu.yaml: - yam/validate/validate_product
schedule/yam/agama_autoyast_supported_s390x.yaml: - yam/validate/validate_product
yes, please.
- Priority changed from High to Normal
- Status changed from In Progress to Resolved
The PR was merged.
I removed the setting of YAML_TEST_DATA: test_data/yam/agama_sap.yaml for the related default installation testsuites for SLES and SLES_SAP, because the test data is useless now, and removed the setting of EXCLUDE_MODULES: 'validate_product' for SLES_SAP testsuites for both prod and dev groups.
Will keep eyes on the next new builds result, and resolve here.
Also available in: Atom
PDF