Project

General

Profile

Actions
Copy link

action #169522

open

coordination #58184: [saga][epic][use case] full version control awareness within openQA

coordination #152847: [epic] version control awareness within openQA for test distributions

git_auto_clone/git_auto_update - Improve error about dirty git checkout size:S

Added by tinita 3 months ago. Updated 2 days ago.

Status:
Workable
Priority:
Normal
Assignee:
-
Category:
Feature requests
Target version:
Ready
Start date:
2024-11-07
Due date:
% Done:

0%

Estimated time:

Description

Motivation

A user saw gru error messages because of a dirty git checkout and didn't know how to handle it:
https://suse.slack.com/archives/C02CANHLANP/p1730970100931999

Nov 07 08:57:26 tmblw-openQA openqa-gru[2287]: [info] Resetting all leftover Gru locks after restart
Nov 07 08:57:26 tmblw-openQA openqa-gru[2287]: [info] Worker 2287 started
Nov 07 08:57:53 tmblw-openQA openqa-gru[2295]: [info] Running cmd: git -C /var/lib/openqa/share/tests/opensuse remote get-url origin
Nov 07 08:57:53 tmblw-openQA openqa-gru[2295]: [info] cmd returned 0
Nov 07 08:57:53 tmblw-openQA openqa-gru[2295]: [info] Running cmd: git -C /var/lib/openqa/share/tests/opensuse diff-index HEAD --exit-code
Nov 07 08:57:53 tmblw-openQA openqa-gru[2295]: [warn] :100644 100644 861ebfa38b757b54d859ced073f247ebc012fcb7 0000000000000000000000000000000000000000 M        lib/dracut_testsuite_test.pm
Nov 07 08:57:53 tmblw-openQA openqa-gru[2295]: [error] cmd returned 256
Nov 07 08:57:53 tmblw-openQA openqa-gru[2295]: [error] Git command failed: git -C /var/lib/openqa/share/tests/opensuse diff-index HEAD --exit-code - Error:
Nov 07 08:58:29 tmblw-openQA openqa-gru[2316]: [info] Running cmd: git -C /var/lib/openqa/share/tests/opensuse remote get-url origin
Nov 07 08:58:29 tmblw-openQA openqa-gru[2316]: [info] cmd returned 0
Nov 07 08:58:29 tmblw-openQA openqa-gru[2316]: [info] Running cmd: git -C /var/lib/openqa/share/tests/opensuse diff-index HEAD --exit-code
Nov 07 08:58:29 tmblw-openQA openqa-gru[2316]: [warn] :100644 100644 861ebfa38b757b54d859ced073f247ebc012fcb7 0000000000000000000000000000000000000000 M        lib/dracut_testsuite_test.pm
Nov 07 08:58:29 tmblw-openQA openqa-gru[2316]: [error] cmd returned 256
Nov 07 08:58:29 tmblw-openQA openqa-gru[2316]: [error] Git command failed: git -C /var/lib/openqa/share/tests/opensuse diff-index HEAD --exit-code - Error:

As we are now (or rather soon) defaulting to git_auto_update, this affects developer instances as well, which usually might not want to have that feature enabled.
The error message should tell the user which feature in openqa.ini to disable.

Acceptance criteria

  • AC1: Clear suggestion to the user what they could/should do

Suggestion

  • Find the code location that triggers to show the output of git diff-index and provide a suggestion to the user, e.g. "Consider to commit your local changes or disable git auto-update, see $link_to_doc for details"
  • No need to prevent the existing log messages, just add one helpful suggestion
Actions
Copy link
 #1

Updated by okurz 3 months ago

  • Parent task set to #152847
Actions
Copy link
 #2

Updated by okurz 3 months ago

  • Target version set to future
Actions
Copy link
 #3

Updated by okurz 3 days ago

  • Target version changed from future to Ready
Actions
Copy link
 #4

Updated by okurz 2 days ago

  • Subject changed from git_auto_clone/git_auto_update - Improve error about dirty git checkout to git_auto_clone/git_auto_update - Improve error about dirty git checkout size:S
  • Description updated (diff)
  • Status changed from New to Workable
Actions
Copy link

Also available in: Atom PDF