action #167971
closedcoordination #58184: [saga][epic][use case] full version control awareness within openQA
coordination #152847: [epic] version control awareness within openQA for test distributions
test detail pages for unfinished jobs on git-cloned test distributions point to invalid source URL
Description
Observation¶
While the test openqa-Tumbleweed-dev-x86_64-Build:TW.31901-openqa_install+publish@64bit-2G https://openqa.opensuse.org/tests/4543834# was running I clicked on a link pointing to the source code of a test module, e.g. https://openqa.opensuse.org/tests/4543834/modules/boot/steps/1/src, redirected to an invalid URL https://github.com/os-autoinst/os-autoinst-distri-openQA/blob///tests/install/boot.pm#, mind the triple ///
. After the test finished the link was to https://github.com/os-autoinst/os-autoinst-distri-openQA/blob/1d419302b4d76093aa572581bd436f9a44227795//tests/install/boot.pm# which is correct and works fine though it still contains a double //
.
Acceptance criteria¶
- AC1: Given a git-cloned test distribution like os-autoinst-distri-openQA When a test is running Then clicking on a module source code link directs to a valid display of the source code currently in use
- AC2: Given a git-cloned test distribution like os-autoinst-distri-openQA When a test is finished Then same result as in AC1
- AC3: Given a legacy cloned test distribution like osado When a test is running Then same result as in AC1 but using the openQA internal source code view using the webUI-local file
Suggestions¶
- This could be a recent regression related to changes how we treat jobs with CASEDIR in settings. Look into the history of changes for potentially related changes
- Ensure this is covered with tests for tests in the "running" state
Updated by tinita about 1 month ago · Edited
- Status changed from New to Feedback
- Assignee set to tinita
https://github.com/os-autoinst/openQA/pull/5989 Fix source view for running tests
Updated by tinita about 1 month ago · Edited
The additional /
is coming from https://github.com/os-autoinst/os-autoinst-distri-openQA/blob/master/main.pm#L16
We should just remove the leading /
.
https://github.com/os-autoinst/os-autoinst-distri-openQA/pull/214
Updated by okurz about 1 month ago
- Status changed from Feedback to Resolved
Both PRs merged, deployed and effective