action #166748
open[MinimalVM] VMware images not handling hdd subfoldes
0%
Description
VMware jobs fail to include images from the hdd/fixed folder, although it works in some cases when the assets are already present on the worker.
The main problems arises in https://github.com/os-autoinst/os-autoinst-distri-opensuse/blob/31dd5c1676685a016198cb1adaac265ef5b48be5/tests/installation/bootloader_svirt.pm#L143 and the following LOC, where handling of subfolders is not properly implemented. This should be done in the backend.
Original ticket¶
This poo is a follow up of issues noted in poo#162941: note-14, note-17, note-24.
In particular:
A) during SL Micro 6.0 Product Increments -VMware tests run, in osado-bootloader_svirt.pm execution, the vmware image full-path is not transferred to the routines managing that file, but only the basename and the path is statically recomposed , assuming no subfoldes for hdd: but those images are in hdd/fixed, instead.
Therefore the bash snippet fails to find the source file, when the basename is not already present in the expected destination folder of the SUT.
B) Moreover, in next runs of those tests, bootloader_svirt.pm passed ok, like 15400838, because the named snippet found the vmware image already in the right place(here transferred by some unknown or manual operation), skipping the copy command.
But leaving that image in the expected place, never cleaned, eventual images update from new builds would be never transferred, therefore not tested.
A possible fix is, sequentially applying the steps:
- update the code in (A) ensuring that the right full-path image is provided as origin in
_copy_image_vmware. - Define a
lock-file policyfor the VMware image (using pre/post_run), to allow transferring that file but preventing that it is cleaned or ovewritten by other similar running tests during elaboration. - Update the
cleanup, like in item n.2 of note-14.