action #164114
closed[Research] Check whether the compare of snapshot occupied disk space mis-consider the unit of size
0%
Description
Motivation¶
Failed job: https://openqa.suse.de/tests/14950309#step/snapper_cleanup_timeline/35
http://openqa.suse.de/tests/14950483#step/snapper_cleanup_timeline/34 got log for the detail info:
[2024-07-17T12:43:44.829590+02:00] [debug] [pid:44352] qgroup_space = 19.73
[2024-07-17T12:43:44.829658+02:00] [debug] [pid:44352] space_limit = 0.5
[2024-07-17T12:43:44.829706+02:00] [debug] [pid:44352] disk_size = 38
19,73 >= 0.5*38 so failed, but in fact 19.73M < 19M of course.
Need double check whether this is a design issue for not consider the unit of size for disk space compare.
Acceptance criteria¶
- AC1: Check whether the compare of snapshot occupied disk space mis-consider the unit
Updated by leli 9 days ago
Checked the man page for btrfs, the cmd used to get qgroup space hasn't set unit for the output.
linux-hxjt:/home/lemon/hackweek # btrfs qgroup show --sync --si / | grep '1/0'
1/0 36.33GB 21.47GB
linux-hxjt:/home/lemon/hackweek # btrfs qgroup show --sync --si --mbytes / | grep '1/0'
1/0 36330.32MB 21473.23MB
linux-hxjt:/home/lemon/hackweek # btrfs qgroup show --sync --si --gbytes / | grep '1/0'
1/0 36.33GB 21.47GB
I will add --gbytes to make it's output as G bytes unit.
Updated by leli 3 days ago
- Status changed from In Progress to Resolved
PR merged. Verified on OSD, https://openqa.suse.de/tests/14999983