action #16362: tests spill out a lot of warnings and fail if PRJDIR is not set - openQA Project - openSUSE Project Management Tool

Actions

Copy link

action #16362

closed

tests spill out a lot of warnings and fail if PRJDIR is not set

Added by okurz about 7 years ago. Updated about 7 years ago.

Status:

Resolved

Priority:

High

Assignee:

oholecek

Category:

Regressions/Crashes

Target version:

Milestone 6

Start date:

2017-01-31

Due date:

% Done:

100%

Estimated time:

Description

observation¶

Use of uninitialized value in index at /usr/lib/os-autoinst/needle.pm line 45.
Use of uninitialized value $bmwqemu::vars{"PRJDIR"} in addition (+) at /usr/lib/os-autoinst/needle.pm line 46.
Use of uninitialized value in index at /usr/lib/os-autoinst/needle.pm line 45.
Use of uninitialized value $bmwqemu::vars{"PRJDIR"} in addition (+) at /usr/lib/os-autoinst/needle.pm line 46.
Use of uninitialized value in index at /usr/lib/os-autoinst/needle.pm line 45.
Use of uninitialized value $bmwqemu::vars{"PRJDIR"} in addition (+) at /usr/lib/os-autoinst/needle.pm line 46.

steps to reproduce¶

Create vars.json as described on https://github.com/os-autoinst/os-autoinst#getting-started
call isotovideo -d
see it fail

expected result¶

probably "PRJDIR" should have some sensible default OR
fail in a more explanatory manner
example vars.json should be working
Make sure example vars.json from documentation is tested, e.g. either test the content of the README.md or do not include in the README but only reference an example file, e.g. the one from the full stack test

Actions

Copy link

Updated by oholecek about 7 years ago

Do I understand it correctly this occurs only when running example vars.json. Or do you see this on some production instance? OpenQA::Worker::Engines::isotovideo::engine_workit adds this to vars.json, but maybe I missed something.

I'm for adding this to example vars.json and add check for presence to isotovideo. Can be?

Actions

Copy link

Updated by okurz about 7 years ago

yes, when working with isotovideo standalone on any vars.json that does not include the PRJDIR variable. I prefer to have the necessary settings in the vars.json as few as possible so that it makes sense to run it also locally standalone on a vars.json file. PRJDIR can be defined as mandatory if that makes sense for that purpose but maybe PRJDIR, CASEDIR, PRODUCTDIR should be revisited if all of them are needed or if sensible defaults can be given.

Actions

Copy link