QA (public) » openQA Project (public) » openQA Tests (public) » Containers and images

I will work on this but it might take some time until I can start.

MR 1977 to refactor the template in order to improve maintenance, using anchors where same settings used: eventual changes in the anchor reflect where called: https://gitlab.suse.de/qac/qac-openqa-yaml/-/merge_requests/1977 MERGED

MR 1974 to add in 420 the tests slem_image_default_test from Core group 534: https://gitlab.suse.de/qac/qac-openqa-yaml/-/merge_requests/1974#note_700056
The original test name - slem_image_default still is in the Core group 534, then until deleted, cannot be used same name. I renamed it as slem_image_default_test and created test suite same name: CI passed ok.
When new tests will be well defined, we can remove duplicates and switch back to the original test name and suite for gr.420, if needed.

After clarifications, a comment to note 17: NO test removal to consider now, only adding tests in group 420, checking coverage responsibilities correctly implemented.

Analysis of slem_image_default_test, in MR1974:

Looking at the osado test code up to date, the entry function for group 420 is in the lib/main_micro_alp.pm, the load_tests() routine.

Focusing on x86_64 first, The code flow of the new test slem_image_default_test , based on current settings provided in yaml of qec gr.420, a.t.m. nearly is the same as the test slem_image_defaut in Core’s group 534, apart enable_selinux, so, placing teams compentences ​side by side, from coverage table named above, the sub load_tests() implements:

LEGEND

This is evident from test https://openqa.suse.de/tests/16103617 in group 534

transactional/transactional_update is not needed for our case

Update: with MR 1977 MERGED, the new added tests slem_image_default_test correctly run and all PASS OK,
see: https://openqa.suse.de/tests/overview?test=slem_image_default_test&groupid=420, i.e. https://openqa.suse.de/tests/16186379

But the test flow still is the full set in https://progress.opensuse.org/issues/161150#note-20, including both QEC + CORE modules.

PR 20797 ongoing to select ownership run: to check the effect, and see the QEC flow only, we run VR clones of new tests in the CASEDIR branch of the PR, adding QEC_SLEM_TESTS_FILTER=1.
The VRs Pass and run the expected modules only.

Basically, the structure of image config tests should be following:

1. load_boot_from_disk_tests
2. load_config_tests
3. load_image_check_tests
4. load_journal_check_tests

The point 3, can be implemented as EXTRA or load_extra_tests. In the worst scenario, it can be a single function but again, that is not really of do not repeat yourself method.

We definitely need to rework the current test load structure, so we split the tests into more specific and hopefully self-explanatory functions. Currently, load_config_tests, load_common_tests and load_transactional_tests ( there might be more cases except of these ) are scheduling a mixture of tests that are not always topic coherent. In a single build, not everyone needs to verify whether libzypp is configured as expected etc

I'll set PR 20797 in draft for now and study the note and possible evolution.

To better catch the structure of the SLE-Micro tests and go forward with the elaboration of the coverage/responsibility, I prepared an UML flow diagram of the main_micro_alp module and published the picture in our Confluence pages, here:
https://confluence.suse.com/display/qasle/SLE+Micro+tests+diagrams.
The actual code version that rendered the pictures is visible here: https://github.com/m-dati/openqa-uml-view/blob/slem_uml/puml/lib/main_micro_alp.puml.

This, to help visualizing the logic status and let ideas to grow, for next updates.