Project

General

Profile

Actions

action #159576

closed

coordination #151990: [epic] Optimize test coverage

Remove test data from console/scc_cleanup_reregister.pm

Added by JERiveraMoya 11 days ago. Updated 7 days ago.

Status:
Rejected
Priority:
Normal
Assignee:
Target version:
-
Start date:
2024-04-24
Due date:
% Done:

0%

Estimated time:

Description

Motivation

As settings seems to be the preferred way to do this, because they are set in mediums and we might need even pair of settings from two different products in the same job, for example for migration, we can remove this functionality. Referring to this:
my $addons = get_test_suite_data()->{addons}; in console/scc_cleanup_reregister.pm
Next function will use SCC_ADDONS by default internally.
Check where this was used with test data and change it so we simplify this module.

Acceptance criteria

  • AC1: Addons are provided via settings and not via test data mechanism.
  • AC2: Other uses of this test module where test data is passed are changed to use settings instead.
Actions #1

Updated by JERiveraMoya 11 days ago

  • Description updated (diff)
Actions #2

Updated by tinawang123 8 days ago

  • Status changed from Workable to In Progress
  • Assignee set to tinawang123
Actions #3

Updated by tinawang123 8 days ago

PR: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/19198
At register_addons_cmd, use get_var('SCC_ADDONS') by default.

Actions #4

Updated by JERiveraMoya 7 days ago

  • Status changed from In Progress to Rejected

I'm working on this, sorry for the colision, I forgot I created it.
Anyway this test module is used with test data so cannot be updated so easily.

Actions

Also available in: Atom PDF