QA

Observation¶

In #112871 we found that it's very difficult to follow the logic, and part of that is the fact that scriptgen.py is used to generate several scripts using variables, configured commands and hard-coded logic to replace literal strings found in either of those.

What if the logic could be changed to run rsync instead of generating scripts? Let's try out how feasible that is.

Acceptance criteria¶

• AC1: Sync can be executed directly without generated code

Suggestions¶

• Change scriptgen.py to execute rsync, possibly use https://github.com/gchamon/sysrsync
• Reduce the magical replacements in the "p" functions
• Error handling within Python code

Out of scope¶

• Complete rewrite of everything
• Changing the plugin completely. This is a spike solution