QA (public) » openQA Project (public)

Observation¶

https://github.com/os-autoinst/os-autoinst/pull/2377 failed the check "codecov/project/fully_covered 99.99% (target 100.00%)" though there are no related changes in this PR. According to https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2377/tree the folder backend is not covered 100%. https://app.codecov.io/gh/os-autoinst/os-autoinst/pull/2377/blob/backend/ipmi.pm#L54 shows the problem in detail

# DELL BMCs are touchy
sub dell_sleep ($self) {
    return unless ($bmwqemu::vars{IPMI_HW} || '') eq 'dell';
    sleep 4; <-- this line
}

likely caused by https://github.com/os-autoinst/os-autoinst/pull/2364 which I merged by mistake.

Acceptance criteria¶

• AC1: "fully_covered" check passes again

Suggestions¶

• Ensure that there is 100% statement coverage again in backend/ipmi.pm. For that you could try to set IPMI_HW=dell. Likely the 4s sleep is already mocked by Test::Mock::Time used in t/29-backend-ipmi.t