Project

General

Profile

Actions
Copy link

action #136151

closed

qem-bot unit testing broken with openqa-client==4.2.2

Added by mpagot about 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
High
Assignee:
tinita
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2023-09-20
Due date:
% Done:

0%

Estimated time:
Tags:
qem-bot

Description

Unit testing, at least as executed in the github action at each PR, are broken.

The workflow is configured to install all the Python dependency from https://github.com/openSUSE/qem-bot/blob/master/requirements-dev.txt that is designed not to have explicit fixed version for each dependency.

The unit test error is like https://github.com/openSUSE/qem-bot/actions/runs/6250035145/job/16968000626#step:5:332

         except Exception as e:
>           (method, url, status_code) = e.args
E           ValueError: too many values to unpack (expected 3)

It is from https://github.com/openSUSE/qem-bot/blob/83c708b55b200f54aae49ab26afe37cbaa652b2a/openqabot/openqa.py#L87

Error is present with openqa-client==4.2.2 and not present with openqa-client==4.2.1

It could be related to https://github.com/os-autoinst/openQA-python-client/pull/35 for https://progress.opensuse.org/issues/120939

Proof for that is https://github.com/openSUSE/qem-bot/pull/136 and passing check in it (PR is only to proof the issue and not a solution for that)

Actions
Copy link
 #1

Updated by tinita about 1 year ago

Actions
Copy link
 #2

Updated by tinita about 1 year ago

  • Status changed from New to In Progress
  • Assignee set to tinita
Actions
Copy link
 #3

Updated by okurz about 1 year ago

Merged, thank you Tina! Rebasing open PRs

Actions
Copy link
 #4

Updated by okurz about 1 year ago

  • Category set to Regressions/Crashes
  • Target version set to Ready
Actions
Copy link
 #5

Updated by openqa_review about 1 year ago

  • Due date set to 2023-10-05

Setting due date based on mean cycle time of SUSE QE Tools

Actions
Copy link
 #6

Updated by okurz about 1 year ago

  • Due date deleted (2023-10-05)
  • Status changed from In Progress to Resolved
Actions
Copy link
 #7

Updated by tinita about 1 year ago

https://github.com/openSUSE/qem-bot/pull/136 proved it was fine

How did this PR prove it was fine? 

# https://patch-diff.githubusercontent.com/raw/openSUSE/qem-bot/pull/136.patch
+++ b/requirements-dev.txt
@@ -4,7 +4,7 @@ coverage
 responses>=0.21.0
 requests
 osc
-openqa-client
+openqa-client==4.2.1

It pinned openqa-client to a version which did not have that new exception parameter.

Actions
Copy link
 #8

Updated by okurz about 1 year ago

Yeah, the change didn't matter only that CI was ok again

Actions
Copy link

Also available in: Atom PDF