Project

General

Profile

Actions

action #135005

open

Reduce duplication in salt-pillars-openqa openqa/workerconf.sls with advanced YAML/jinja features

Added by okurz 9 months ago. Updated 9 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
2023-09-01
Due date:
% Done:

0%

Estimated time:
Tags:

Description

Motivation

See https://gitlab.suse.de/openqa/salt-pillars-openqa/-/merge_requests/582#note_530351

sls files for Salt are Jinja templates. After jinja processing they result in YAML files, and only then can be checked for the correct YAML syntax.
That means we cannot just use a linter on those files in merge requests.

The files can grow quite large, so it's hard to manually review if the YAML would look actually correct. Using aliases and merge keys (<<) could help reducing the size, but checking aliases manually close to impossible, because you have to keep track of where they are created (anchors) and used, and if there is no typo.

A linter can do that. However there seems to be no way to run salt in a dry mode to automatically test all possible jinja values.

Suggestions

  • How about trying to fill in example values for jinja processing and then check the resulting YAML?

Related issues 1 (0 open1 closed)

Related to openQA Infrastructure - action #116845: salt-states-openqa CI complains about "fatal: Authentication failed for 'https://gitlab.suse.de/openqa/salt-pillars-openqa/'" but no useful hint size:MResolvedmkittler2022-09-20

Actions
Actions

Also available in: Atom PDF