action #134597
closedFix Fallout of PR#2342
Added by mdati over 1 year ago. Updated over 1 year ago.
0%
Description
os-autoinst-distri-openSUSE PR#2342 causes some test failures due to a newly introduced command check. This ticket collects all occurring failures and coordinates the effort to fix them.
Updated by ph03nix over 1 year ago
- Subject changed from test fails in any script_run call including a newline to Fix Fallout of PR#2342
- Description updated (diff)
- Status changed from New to Workable
- Priority changed from Normal to Urgent
Updated by mdati over 1 year ago
Impacted by the issue, crashed in transfer_repos
, tests of test group Maint Pub.Cloud Updates, like these:
https://openqa.suse.de/tests/11904992#step/transfer_repos/333
https://openqa.suse.de/tests/11904987#step/transfer_repos/333
https://openqa.suse.de/tests/11905055#step/transfer_repos/375
https://openqa.suse.de/tests/11905084#step/transfer_repos/375
Short analysis:
All above tests failed in code transfer_repos due to previous line 54 containing '\n' newlines in the command to execute (due to echo
), so causing failure:
in distribution::L119, being newline not supported for the named PR.
Updated by ph03nix over 1 year ago
gnutls_server but that's not really in our squad's test modules list.
Updated by ph03nix over 1 year ago
- Checklist item transfer_repos added
- Checklist item podman_volumes added
Updated by rbranco over 1 year ago
The volumes test was fixed in https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/17637
Updated by rbranco over 1 year ago
Updated by mdati over 1 year ago
Here is a list of openqa modules as of now impacted, having explicitly into the command a \n: script_run.*\\n
- tests:
tests/boot/grub2_test.pm
tests/containers/volumes.pm
tests/containers/podman_netavark.pm
tests/jeos/prepare_openstack.pm
tests/microos/toolbox.pm
tests/network/cifs.pm
tests/qa_automation/qaset_post_patch_run.pm
tests/rt/rt_chrt.pm
tests/security/postgresql_ssl/postgresql_ssl_server.pm
tests/virt_autotest/switch_to_ssh_and_install_hypervisor.pm
tests/virt_autotest/sriov_network_card_pci_passthrough.pm
tests/x11/vnc_two_passwords.pm
tests/x11/firefox.pm
tests/xfstests/run.pm
Also check named string in all module.pm of:
tests/console/
tests/virt_autotest/
- lib :
lib/alp_workloads/kvm_workload_utils.pm
lib/apachetest.pm
lib/containers/podman.pm
lib/publiccloud/utils.pm
lib/rpi.pm
lib/saltbase.pm
lib/utils.pm
lib/virt_autotest/utils.pm
lib/virt_autotest/utils.pm
lib/wickedbase.pm
Also check named string in all module.pm of:
lib/hpc/
Some modules may be are not checked yet: suggested to do fixes by sub-groups and after merged, to repeat the issue search for remaining modules to fix.
Still to check also eventual indirect insertion of \n in variables ($cmd), before the execution in
script_run($cmd,...)
.Other lib or tests areas like kernel and SAP are impacted.
Updated by rbranco over 1 year ago
Updated by mdati over 1 year ago
- Checklist item gnutls_server added
see test
sle-micro-5.3-MicroOS-Image-Updates-aarch64-Build20230823-1-slem_fips@aarch64
https://openqa.suse.de/tests/11911905#
Updated by rbranco over 1 year ago
mdati wrote in #note-17:
see test
sle-micro-5.3-MicroOS-Image-Updates-aarch64-Build20230823-1-slem_fips@aarch64
https://openqa.suse.de/tests/11911905#
This module belongs to the Security Team...
Updated by mdati over 1 year ago
- Checklist item gpg added
see tests
sle-15-SP5-EC2-BYOS-Updates-aarch64-Build20230823-1-publiccloud_consoletests@64bit
https://openqa.suse.de/tests/11912295#step/gpg/14
https://openqa.suse.de/tests/11912299#step/gpg/14
Updated by rbranco over 1 year ago
- Status changed from Resolved to In Progress
- Assignee changed from rbranco to mdati
Updated by mdati over 1 year ago
- Checklist item deleted (
gnutls_server)
See notes above n.4 and n.18
Updated by mdati over 1 year ago
- Checklist item deleted (
gpg) - Status changed from Workable to Resolved
tests/console/gpg is managed by other team.