Project

General

Profile

Actions

action #134597

closed

Fix Fallout of PR#2342

Added by mdati 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
Bugs in existing tests
Target version:
-
Start date:
2023-08-24
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

os-autoinst-distri-openSUSE PR#2342 causes some test failures due to a newly introduced command check. This ticket collects all occurring failures and coordinates the effort to fix them.


Checklist

  • transfer_repos
  • podman_volumes
Actions #1

Updated by ph03nix 9 months ago

  • Subject changed from test fails in any script_run call including a newline to Fix Fallout of PR#2342
  • Description updated (diff)
  • Status changed from New to Workable
  • Priority changed from Normal to Urgent
Actions #2

Updated by ph03nix 9 months ago

Actions #3

Updated by mdati 9 months ago

Impacted by the issue, crashed in transfer_repos, tests of test group Maint Pub.Cloud Updates, like these:
https://openqa.suse.de/tests/11904992#step/transfer_repos/333
https://openqa.suse.de/tests/11904987#step/transfer_repos/333
https://openqa.suse.de/tests/11905055#step/transfer_repos/375
https://openqa.suse.de/tests/11905084#step/transfer_repos/375

Short analysis:
All above tests failed in code transfer_repos due to previous line 54 containing '\n' newlines in the command to execute (due to echo), so causing failure:
in distribution::L119, being newline not supported for the named PR.

Actions #4

Updated by ph03nix 9 months ago

gnutls_server but that's not really in our squad's test modules list.

Actions #5

Updated by ph03nix 9 months ago

  • Checklist item transfer_repos added
  • Checklist item podman_volumes added
Actions #6

Updated by ph03nix 9 months ago

  • Checklist item podman_volumes set to Done
Actions #7

Updated by ph03nix 9 months ago

I'll take the volumes test.

Actions #10

Updated by rbranco 9 months ago

  • Assignee set to rbranco
Actions #11

Updated by rbranco 9 months ago

  • Priority changed from Urgent to High
Actions #12

Updated by rbranco 9 months ago

  • Status changed from Workable to In Progress
Actions #13

Updated by mdati 9 months ago

Here is a list of openqa modules as of now impacted, having explicitly into the command a \n: script_run.*\\n

  • tests:

tests/boot/grub2_test.pm
tests/containers/volumes.pm
tests/containers/podman_netavark.pm
tests/jeos/prepare_openstack.pm
tests/microos/toolbox.pm
tests/network/cifs.pm
tests/qa_automation/qaset_post_patch_run.pm
tests/rt/rt_chrt.pm
tests/security/postgresql_ssl/postgresql_ssl_server.pm
tests/virt_autotest/switch_to_ssh_and_install_hypervisor.pm
tests/virt_autotest/sriov_network_card_pci_passthrough.pm
tests/x11/vnc_two_passwords.pm
tests/x11/firefox.pm
tests/xfstests/run.pm

Also check named string in all module.pm of:
tests/console/
tests/virt_autotest/

  • lib :

lib/alp_workloads/kvm_workload_utils.pm
lib/apachetest.pm
lib/containers/podman.pm
lib/publiccloud/utils.pm
lib/rpi.pm
lib/saltbase.pm
lib/utils.pm
lib/virt_autotest/utils.pm
lib/virt_autotest/utils.pm
lib/wickedbase.pm

Also check named string in all module.pm of:
lib/hpc/

  • Some modules may be are not checked yet: suggested to do fixes by sub-groups and after merged, to repeat the issue search for remaining modules to fix.

  • Still to check also eventual indirect insertion of \n in variables ($cmd), before the execution in script_run($cmd,...).

  • Other lib or tests areas like kernel and SAP are impacted.

Actions #14

Updated by rbranco 9 months ago

  • Checklist item transfer_repos set to Done
Actions #16

Updated by rbranco 9 months ago

  • Status changed from In Progress to Resolved
Actions #17

Updated by mdati 9 months ago

  • Checklist item gnutls_server added

see test
sle-micro-5.3-MicroOS-Image-Updates-aarch64-Build20230823-1-slem_fips@aarch64
https://openqa.suse.de/tests/11911905#

Actions #18

Updated by rbranco 9 months ago

mdati wrote in #note-17:

see test
sle-micro-5.3-MicroOS-Image-Updates-aarch64-Build20230823-1-slem_fips@aarch64
https://openqa.suse.de/tests/11911905#

This module belongs to the Security Team...

Actions #19

Updated by mdati 9 months ago

  • Checklist item gpg added

see tests
sle-15-SP5-EC2-BYOS-Updates-aarch64-Build20230823-1-publiccloud_consoletests@64bit

https://openqa.suse.de/tests/11912295#step/gpg/14
https://openqa.suse.de/tests/11912299#step/gpg/14

Actions #20

Updated by rbranco 9 months ago

  • Status changed from Resolved to In Progress
  • Assignee changed from rbranco to mdati
Actions #21

Updated by mdati 9 months ago

  • Assignee deleted (mdati)
Actions #22

Updated by mdati 9 months ago

  • Checklist item deleted (gnutls_server)

See notes above n.4 and n.18

Actions #23

Updated by mdati 9 months ago

  • Status changed from In Progress to Workable
Actions #24

Updated by mdati 9 months ago

  • Checklist item deleted (gpg)
  • Status changed from Workable to Resolved

tests/console/gpg is managed by other team.

Actions

Also available in: Atom PDF