action #134441: Create CI/CD with github actions for jknphy / e2e-agama-playwright - qe-yam - openSUSE Project Management Tool

Actions

Copy link

action #134441

closed

Create CI/CD with github actions for jknphy / e2e-agama-playwright

Added by syrianidou_sofia 9 months ago. Updated 5 months ago.

Status:

Resolved

Priority:

Low

Assignee:

syrianidou_sofia

Target version:

Current

Start date:

2023-08-19

Due date:

% Done:

Estimated time:

Description

Currently, the github repo for Playwright tests does not contain any CI/CD checks for the code to merge. We need to do the full code review manually. We could add some checks like code formatting, filenames ending, pages files being strictly in an agreed folder etc..

Acceptance criteria

Design the main CI/CD format
Add some basic check
Create follow up tickets for any additional check.

Actions

Copy link

Updated by JERiveraMoya 9 months ago

Feels a bit soon to know what check we need, full review is going to be needed anyway.
The only point I see interesting is the one with format if not everybody is using VSCode... the ticket could be just about to force the same format that the vscode offers for the ones not using it (because in this case it is a great fit, due to Playwright is from Microsoft). wdyt?

Actions

Copy link

Updated by JERiveraMoya 9 months ago

Feels a bit soon to know what checks we need, full review is going to be needed anyway.
The only point I see interesting is the one with format if not everybody is using VSCode... the ticket could be just about to force the same format that the vscode offers for the ones not using it (because in this case it is a great fit, due to Playwright is from Microsoft). wdyt?

Actions

Copy link

Updated by syrianidou_sofia 9 months ago

Yes, it's too soon indeed. I opened this ticket mainly to set the base for a CI. We can implement just the basic check for formatting and open follow up tickets later for additional checks. For example, I once forgot a to close some bracket at the end of my code and the CI was green. We can deal with formatting in this ticket and open follow up ticket for typescript syntax, at this stage.

Actions

Copy link