QA

I asked in #help-obs.
Looking at the qem-bot code, the API request for 304153 and others must have returned 404, although they are older and must have existed already.

Looking at the docs of POST /request/id, it's possible that they changed the 403 to a 404, so it could be really just a "request is not in review state" which means it's likely already approved.

edit: but if I try it out for https://build.suse.de/request/show/304153 , I get a "403 The request is neither in state review nor new", so maybe that's just wrong documentation.

Looking at the docs of POST /request/id, it's possible that they changed the 403 to a 404

The "Not found" example in the docs says Couldn't find request with id '120', though?

We can at least get the headers from the HTTPError. Interestingly the unit test for 404 is using the wrong strings but it's expecting it to fail. So I'm for now assuming that is the behavior that was desired:

https://github.com/openSUSE/qem-bot/pull/129

Getting the response body would be even better I guess, but not sure how to get that.

livdywan wrote:

Looking at the docs of POST /request/id, it's possible that they changed the 403 to a 404

The "Not found" example in the docs says Couldn't find request with id '120', though?

Are you looking at the actual documentation for POST /request/id? It looks like what you are quoting is for the GET request.

tinita wrote:

livdywan wrote:

Looking at the docs of POST /request/id, it's possible that they changed the 403 to a 404

The "Not found" example in the docs says Couldn't find request with id '120', though?

Are you looking at the actual documentation for POST /request/id? It looks like what you are quoting is for the GET request.

Yes. You can select the example in the combo box. GET only has one possible outcome.

For GET /request/id we see this documentation:

404 
Not Found

Media type

application/xml; charset=utf-8
Example Value
Schema
<?xml version="1.0" encoding="UTF-8"?>
<status code="not_found">
    <summary>Couldn&apos;t find request with id &apos;5&apos;</summary>
</status>

For POST /request/id we see this documentation:

404 
Not Found

Media type

application/xml; charset=utf-8
Examples

Request Not Modifiable
Example Value
Schema
<?xml version="1.0" encoding="UTF-8"?>
<status code="request_not_modifiable">
    <summary>request is not in review state</summary>
</status>

And since in qem-bot we are doing a POST request, this should be the relevant one.

When I try it for 304153 out I get:

# Headers
status: 403 Forbidden
x-opensuse-errorcode: review_change_state_no_permission
...
# Body
<status code="review_change_state_no_permission">
  <summary>The request is neither in state review nor new</summary>
</status>

So I'm assuming we're fine, because the request was accepted before, it's just that the documentation talks about a 404, and apparently that's what we're getting, but I get a 403 with a similar error, so to be sure we could just log the body for now.