action #132920
closedcoordination #121864: [epic] Split and enhance test modules in migrations
Split logic for recently created deregister_dropped_modules.pm
Description
Motivation¶
It should be more clear just looking at the test module what are the actions in drop_unavailable_product_modules.pm
Of course, we are talking about the function sub deregister_dropped_modules
to extract its logic in different test modules, the code is just iterating over comma-separated values in settings, creating unnecessary complexity. We need test modules which address specific actions in a very straightforward way and very transparent display, so any user (ie: a developer in a bug report) could reproduce manually this. This piece of code seems to be doing:
This block deals with LTSS, it should have its own test module with name (according to documentation disable_ltss.pm (let's use some hash instead of if/else conditions here)
remove_suseconnect_product('SLE_HPC-LTSS');
remove_suseconnect_product('SLES-LTSS');
Do we really use or need this part in the YaM scope?
zypper_call 'rm -t product SLES-LTSS';
zypper_call 'rm sles-ltss-release-POOL';
We don't need setting DROPPED_MODULES because the only other case to be taking into account is the python2 so let's create a test module only for this
remove_suseconnect_product(get_addon_fullname($name));
Finally after each the two modules create above we might need to adjust the settings, but I don't think it is responsibility of this module to do this, during the migration itself ltss or python can be excluded. File a ticket to adjust it there if it is not possible at the moment and keep this code or even better fix it there on target.
@all_addons = grep { $_ ne $name } @all_addons;
set_var('SCC_ADDONS', join(',', @all_addons));
Acceptance criteria¶
AC1: Split/improve this piece of logic following recommendations above
Additional information¶
Refactored test suite are currently in this job group with names ending on *_split_patch_sle
.
Updated by zoecao over 1 year ago
- Status changed from Workable to In Progress
- Assignee set to zoecao
Updated by zoecao about 1 year ago
Cost a few days to review agama new builds this week, I'll continue to work on this ticket now.
Updated by zoecao about 1 year ago
Because the supported hpc migration path doesn't include older scenarios, so we don't have ltss testing in hpc migration cases, so I didn't add SLE_HPC-LTSS to the deregister_ltss text module to make the code more clear.
https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/17750
Updated by zoecao about 1 year ago
Re-triggered the related jobs in migration dev job group, may need to file a new ticket if any new issues caused by:
@all_addons = grep { $_ ne $name } @all_addons;
set_var('SCC_ADDONS', join(',', @all_addons));
https://openqa.suse.de/tests/12439156#live
https://openqa.suse.de/tests/12439157#live
Updated by zoecao about 1 year ago
And submit a MR to update the split patch_sle case setting.
https://gitlab.suse.de/coolgw/wegao-test/-/merge_requests/353
File one ticket for the caused failure in [addon_products_sle]:
ticket link: https://progress.opensuse.org/issues/138179