Project

General

Profile

Actions
Copy link

action #128783

closed

failed job red is now too dark and similar to incomplete

Added by okurz 12 months ago. Updated 12 months ago.

Status:
Resolved
Priority:
High
Assignee:
mkittler
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2023-05-05
Due date:
% Done:

0%

Estimated time:

Description

Observation

https://openqa.opensuse.org/tests?resultfilter=Failed&resultfilter=Incomplete

Acceptance criteria

  • AC1: Red in favicon and bubble is same
  • AC2: failed + incomplete can be distinguished (I was happy with what we had before)
  • AC3: contrast between failed and background in both bright and dark mode is ok

Suggestions

  • Crosscheck one of the latest PRs that introduced the change
Actions
Copy link
 #1

Updated by okurz 12 months ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by mkittler 12 months ago

  • Status changed from New to Feedback
  • Assignee set to mkittler
Actions
Copy link
 #3

Updated by mkittler 12 months ago

  • Status changed from Feedback to Resolved

The PR has been merged and it definitely fulfills the ACs as it simply reverts the color of failed to what it was before (which was always acceptable). The contrast issue of the progress bar segment remains resolved, see https://github.com/os-autoinst/openQA/pull/5121#issuecomment-1535944554.

We could still improve the consistency of the progress bar coloring but I supposed that's outside of the scope of this ticket.

Actions
Copy link

Also available in: Atom PDF