Project

General

Profile

Actions

action #128588

closed

Investigation Tab broken for some jobs size:M

Added by tinita 12 months ago. Updated 11 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Regressions/Crashes
Target version:
Start date:
2023-05-03
Due date:
% Done:

0%

Estimated time:

Description

Observation

In https://openqa.opensuse.org/tests/3260493#investigation and https://openqa.opensuse.org/tests/3260745#investigation the tab is loading forever. The console points to a Javascript error:

test_result.js:105 Uncaught TypeError: Cannot read properties of null (reading '1')
    at githashToLink (test_result.js:105:218)
    at test_result.js:127:1680
    at Array.forEach (<anonymous>)
    at Object.renderInvestigationTab [as renderContents] (test_result.js:127:747)
    at Object.success (test_result.js:85:187)
    at fire (bootstrap.js:245:231)
    at Object.fireWith [as resolveWith] (bootstrap.js:251:181)
    at done (bootstrap.js:680:95)
    at XMLHttpRequest.<anonymous> (bootstrap.js:693:314)
function githashToLink(value, repo) {
    const logItems = value.split(/(?=^[0-9a-f])/gm);
    const commits = [];
    for (let i = 0; i < logItems.length; i++) {
        const item = logItems[i];
        const match = item.match(/^([0-9a-f]{9}) (.*)/);
        const sha = match[1];            // <--------
        const msg = match[2];
        commits.push({
            link: sha.link(repo + sha),
            msg: msg,
            stat: item.match(/^ .*/gm)
        });
    }
    return commits;
}

Steps to reproduce

Acceptance criteria

  • AC1: No more JavaScript errors on the investigation tab (done)
  • AC2: A ui test exists

Suggestions

Actions #1

Updated by okurz 12 months ago

  • Target version set to Ready
Actions #2

Updated by okurz 12 months ago

  • Subject changed from Investigation Tab broken for some jobs to Investigation Tab broken for some jobs size:M
  • Description updated (diff)
  • Status changed from New to Workable
Actions #3

Updated by tinita 12 months ago

  • Status changed from Workable to In Progress
  • Assignee set to tinita
Actions #4

Updated by tinita 12 months ago

  • Status changed from In Progress to Feedback

https://github.com/os-autoinst/openQA/pull/5126 Improve non-matching log output in investigation tab

Actions #5

Updated by tinita 12 months ago

  • Status changed from Feedback to In Progress

https://github.com/os-autoinst/openQA/pull/5126 merged, now trying to add a test

Actions #6

Updated by tinita 12 months ago

  • Description updated (diff)
  • Status changed from In Progress to Workable
  • Assignee deleted (tinita)

Actually there are more urgent tasks, so I put this back to workable for now

Actions #7

Updated by tinita 12 months ago

  • Description updated (diff)
Actions #8

Updated by mkittler 11 months ago

  • Status changed from Workable to In Progress
  • Assignee set to mkittler
Actions #9

Updated by mkittler 11 months ago

  • Status changed from In Progress to Feedback
Actions #10

Updated by okurz 11 months ago

  • Status changed from Feedback to Resolved

https://github.com/os-autoinst/openQA/pull/5182 merged, AC2 covered now as well

Actions

Also available in: Atom PDF