Project

General

Profile

Actions
Copy link

action #124476

closed

Rendering of git log is off by one on the webUI side.

Added by szarate almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
tinita
Category:
Regressions/Crashes
Target version:
Ready
Start date:
2023-02-14
Due date:
% Done:

0%

Estimated time:
Tags:
reactive work

Description

See: https://suse.slack.com/archives/C02CANHLANP/p1676371884214859

Possibly the bug is test_result.js

TL;DR: The latest commit is not being rendered on the javascript side, since when looking at the XHR data, I can clearly see the latest commits:

1983f2ab7 Fix product shortcuts for SLE 15 SP5 < -- This is missing
6f92871b0 Add wait_still_screen for for needle matching
...
7fb0e326c Fix pycairo module in tumbleweed

You can see the same result in other jobs: https://openqa.suse.de/tests/10492073#investigation

157c1395f Fix --beta flag during img_poof execution <-- Not displayed
06dfa693d Move PAM testing after registration
a39412717 Increase timeout in sles4sap/sap_suse_cluster_connector
...
Actions
Copy link
 #1

Updated by okurz almost 2 years ago

  • Tags set to reactive work
  • Category set to Regressions/Crashes
  • Target version set to future

wow, so you already almost fixed it already :)

Actions
Copy link
 #2

Updated by tinita almost 2 years ago

The problem is actually here:
https://github.com/os-autoinst/openQA/blob/7ecfb9e5641a6af67dc281bf093bdd77d4124efa/assets/javascripts/test_result.js#L605

function githashToLink(value, repo) {
  const logItems = value.split(/(?=^[0-9a-f])/gm);
  logItems.shift();

And the reason for that is, that the git log output contained a preceding linebreak.

That was removed at some point, and our tests only work with a fixed git log example, so we never saw the regression :(

https://github.com/os-autoinst/openQA/blob/7ecfb9e5641a6af67dc281bf093bdd77d4124efa/lib/OpenQA/Schema/Result/Jobs.pm#L1850
https://github.com/os-autoinst/openQA/commit/6b31bdb8acd007de140fe4b7018817e7092174e3

Actions
Copy link
 #3

Updated by tinita almost 2 years ago

  • Status changed from New to In Progress
  • Assignee set to tinita
  • Target version changed from future to Ready
Actions
Copy link
 #4

Updated by tinita almost 2 years ago

  • Status changed from In Progress to Feedback
Actions
Copy link
 #5

Updated by tinita almost 2 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF