Project

General

Profile

action #120900

Required patterns values are not removed on select_patterns

Added by ybonatakis 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Bugs in existing tests
Target version:
-
Start date:
2022-11-23
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

Observation

I am not sure if the title is accurate. What actually happens can be seen on the attached screen select_patterns
The specific job set PATTERNS": "base,minimal,apparmor" but at the end only minimal and apparmor are selected. The problem is that another pattern is deselected after the base is checked.
Due to the logic of the select_specific_patterns_by_iteration function, which iterates from top to bottom, it can happen a previous pattern to alter as a dependency of another selection/deselection on a later checkbox.

Also i found the code a bit complicated. For starters there is two different approaches to uncheck patterns

  1. $self->deselect_pattern() if get_var('EXCLUDE_PATTERNS');
  2. inside select_specific_patterns_by_iteration using minus notation on PATTERNS.

I think this is unnecessarily complexity
Also i believe that the process_patterns should take care and acts of defaults PATTERNS. As now the logic is inside select_specific_patterns_by_iteration

This ticket to improve and improve in all the above. I dont think this is high priority -nor even normal- as it doesnt have destructive impact on the most of the test cases but hides a seriously defect which produces an unexpected installation than the one was set it up for.

Reproducible

To reproduce you can set PATTERNS": "base,minimal,apparmor" and choose a job which by default has GNOME checked. At the end of the select_specific_patterns_by_iteration review the installation settings window before the installation

Expected result

PATTERNS values are ensured are selected at the end of the process_patterns

Also available in: Atom PDF