Actions
action #120729
closedcoordination #68794: [qe-core][functional][epic] rework postfail hooks
[qe-core] *basetest::post_fail_hook: leave early if `NOLOGS` is set
Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
Start date:
2022-11-18
Due date:
% Done:
0%
Estimated time:
Difficulty:
Sprint:
QE-Core: December Sprint (Dec 07 - Jan 11)
Description
For some reason, somebody might not want to collect logs, but still run the post_fail_hooks, and we only have that for opensusebasetest but not for subclasses of it and we should
This will help to run the post_fail_hooks of specific test modules that are also calling $self->SUPER::post_fail_hook where collecting those extra logs isn't really necessary
Acceptance Criteria¶
- AC1: opensusebasetest and all its subclasses, first check for
NOLOGSand leave if it's set - AC2: Variable is documented in variables.md
Updated by szarate about 2 years ago
- Copied from action #120723: [qe-core] Guarantee `show_tasks_in_blocked_state` will always be called added
Updated by rfan1 about 2 years ago
- Status changed from Workable to In Progress
- Assignee set to rfan1
Let me try to add this logic
Updated by rfan1 about 2 years ago
http://w3.suse.de/~szarate/perl-analyzer/ can help me to find the subclass tree
Updated by rfan1 about 2 years ago
I wrote a simple script to find all classes which use post_fail_hook under opensusebasetest tree.
#!/bin/bash
for i in `grep -nr $1 * |grep "use base" |awk -F \: '{print $1}'`
do grep -nr "SUPER::post_fail_hook" $i > /dev/null
if [ $? -eq 0 ]; then
echo $i
fi
done
Updated by rfan1 about 2 years ago
Updated by szarate almost 2 years ago
- Sprint changed from QE-Core: November Sprint (Nov 09 - Dec 07) to QE-Core: December Sprint (Dec 07 - Jan 04)
Actions