Project

General

Profile

Actions

action #120729

closed

coordination #68794: [qe-core][functional][epic] rework postfail hooks

[qe-core] *basetest::post_fail_hook: leave early if `NOLOGS` is set

Added by szarate over 1 year ago. Updated about 1 year ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
Start date:
2022-11-18
Due date:
% Done:

0%

Estimated time:
Difficulty:
Sprint:
QE-Core: December Sprint (Dec 07 - Jan 11)

Description

For some reason, somebody might not want to collect logs, but still run the post_fail_hooks, and we only have that for opensusebasetest but not for subclasses of it and we should

This will help to run the post_fail_hooks of specific test modules that are also calling $self->SUPER::post_fail_hook where collecting those extra logs isn't really necessary

Acceptance Criteria

  1. AC1: opensusebasetest and all its subclasses, first check for NOLOGS and leave if it's set
  2. AC2: Variable is documented in variables.md

Related issues 1 (0 open1 closed)

Copied from openQA Tests - action #120723: [qe-core] Guarantee `show_tasks_in_blocked_state` will always be calledResolveddzedro2022-11-18

Actions
Actions #1

Updated by szarate over 1 year ago

  • Copied from action #120723: [qe-core] Guarantee `show_tasks_in_blocked_state` will always be called added
Actions #2

Updated by rfan1 over 1 year ago

  • Status changed from Workable to In Progress
  • Assignee set to rfan1

Let me try to add this logic

Actions #3

Updated by rfan1 over 1 year ago

http://w3.suse.de/~szarate/perl-analyzer/ can help me to find the subclass tree

Actions #4

Updated by rfan1 over 1 year ago

I wrote a simple script to find all classes which use post_fail_hook under opensusebasetest tree.

#!/bin/bash

for i in `grep -nr $1 * |grep "use base" |awk -F \: '{print $1}'`
do grep -nr "SUPER::post_fail_hook" $i > /dev/null
 if [ $? -eq 0 ]; then
   echo $i
 fi
done

Actions #6

Updated by szarate over 1 year ago

  • Sprint changed from QE-Core: November Sprint (Nov 09 - Dec 07) to QE-Core: December Sprint (Dec 07 - Jan 04)
Actions #7

Updated by rfan1 over 1 year ago

  • Status changed from In Progress to Feedback
Actions #8

Updated by rfan1 about 1 year ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF