Project

General

Profile

action #120729

coordination #68794: [qe-core][functional][epic] rework postfail hooks

[qe-core] *basetest::post_fail_hook: leave early if `NOLOGS` is set

Added by szarate 3 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
Start date:
2022-11-18
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

For some reason, somebody might not want to collect logs, but still run the post_fail_hooks, and we only have that for opensusebasetest but not for subclasses of it and we should

This will help to run the post_fail_hooks of specific test modules that are also calling $self->SUPER::post_fail_hook where collecting those extra logs isn't really necessary

Acceptance Criteria

  1. AC1: opensusebasetest and all its subclasses, first check for NOLOGS and leave if it's set
  2. AC2: Variable is documented in variables.md

Related issues

Copied from openQA Tests - action #120723: [qe-core] Guarantee `show_tasks_in_blocked_state` will always be calledResolved2022-11-18

History

#1 Updated by szarate 3 months ago

  • Copied from action #120723: [qe-core] Guarantee `show_tasks_in_blocked_state` will always be called added

#2 Updated by rfan1 3 months ago

  • Status changed from Workable to In Progress
  • Assignee set to rfan1

Let me try to add this logic

#3 Updated by rfan1 3 months ago

http://w3.suse.de/~szarate/perl-analyzer/ can help me to find the subclass tree

#4 Updated by rfan1 3 months ago

I wrote a simple script to find all classes which use post_fail_hook under opensusebasetest tree.

#!/bin/bash

for i in `grep -nr $1 * |grep "use base" |awk -F \: '{print $1}'`
do grep -nr "SUPER::post_fail_hook" $i > /dev/null
 if [ $? -eq 0 ]; then
   echo $i
 fi
done

#6 Updated by szarate 2 months ago

  • Sprint changed from QE-Core: November Sprint (Nov 09 - Dec 07) to QE-Core: December Sprint (Dec 07 - Jan 04)

#7 Updated by rfan1 about 2 months ago

  • Status changed from In Progress to Feedback

#8 Updated by rfan1 about 1 month ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF