action #120639
closedcoordination #121876: [epic] Handle openQA review failures in Yam squad - SLE 15 SP5
Fix check for network restart in yast2_lan_restart* test modules
Description
Motivation¶
We observe the situation that in all yast2_lan_restart*
tests we get a failure because in fact the network gets reloaded when it shouldn't be.
- https://openqa.suse.de/tests/9954571#step/yast2_lan_restart_bridge/64
- https://openqa.suse.de/tests/9954571#step/yast2_lan_restart_vlan/56
- https://openqa.suse.de/tests/9954571#step/yast2_lan_restart_bond/61
Because of this I filed bsc#1205402 for the current build.
The first comment states:
Does this test use the "Next" button to get out of the YaST network module?
In that case, it might happen that network settings are applied even though there was no real change. In some scenarios, this might even be desired; for example when a user wishes to restart the network (in case of unknown networking problems).
If you know there was no change, and you want to leave a YaST module without restarting anything, please use the "Cancel" button.
Looking at the code I must confirm this:
- The test module issues a
$network_settings->save_changes();
save_changes()
performs$self->get_action_buttons()->press_ok();
inNetworkSettings/v4_3/NetworkSettingsController.pm
ActionButtons.pm
assignspres_ok
to the$self->{btn_ok} = $self->{app}->button({id => 'next'});
ToDo to fix this¶
- Add code to handle the
cancel
button inActionButtons.pm
andNetworkSettingsController.pm
- Modify test modules so that they issue the
cancel
button instead ofnext
Acceptance criteria¶
AC1: Problem is fixed for all yast2_lan_restart*
test modules
Updated by JERiveraMoya almost 2 years ago
- Tags set to qe-yast-refinement
- Target version set to Current
Updated by JERiveraMoya almost 2 years ago
- Tags deleted (
qe-yast-refinement) - Status changed from New to Workable
Updated by zoecao almost 2 years ago
- Status changed from Workable to In Progress
- Assignee set to zoecao
Updated by zoecao almost 2 years ago
Created a pr to fix this ticket, but the github is hard to access today, so will post the PR link here later.
VR for this ticket: https://openqa.suse.de/tests/10090473
Updated by zoecao almost 2 years ago
PR for this ticket: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/16055
Updated by zoecao almost 2 years ago
- Status changed from In Progress to Resolved
PR is merged, so close here, thanks.