Project

General

Profile

Actions

action #120639

closed

coordination #121876: [epic] Handle openQA review failures in Yam squad - SLE 15 SP5

Fix check for network restart in yast2_lan_restart* test modules

Added by rainerkoenig almost 2 years ago. Updated almost 2 years ago.

Status:
Resolved
Priority:
High
Assignee:
Target version:
Start date:
2022-11-16
Due date:
% Done:

0%

Estimated time:

Description

Motivation

We observe the situation that in all yast2_lan_restart* tests we get a failure because in fact the network gets reloaded when it shouldn't be.

Because of this I filed bsc#1205402 for the current build.
The first comment states:

Does this test use the "Next" button to get out of the YaST network module?

In that case, it might happen that network settings are applied even though there was no real change. In some scenarios, this might even be desired; for example when a user wishes to restart the network (in case of unknown networking problems).

If you know there was no change, and you want to leave a YaST module without restarting anything, please use the "Cancel" button.

Looking at the code I must confirm this:

  • The test module issues a $network_settings->save_changes();
  • save_changes() performs $self->get_action_buttons()->press_ok(); in NetworkSettings/v4_3/NetworkSettingsController.pm
  • ActionButtons.pm assigns pres_ok to the $self->{btn_ok} = $self->{app}->button({id => 'next'});

ToDo to fix this

  • Add code to handle the cancel button in ActionButtons.pm and NetworkSettingsController.pm
  • Modify test modules so that they issue the cancel button instead of next

Acceptance criteria

AC1: Problem is fixed for all yast2_lan_restart* test modules

Actions #1

Updated by JERiveraMoya almost 2 years ago

  • Tags set to qe-yast-refinement
  • Target version set to Current
Actions #2

Updated by JERiveraMoya almost 2 years ago

  • Priority changed from Normal to High
Actions #3

Updated by JERiveraMoya almost 2 years ago

  • Tags deleted (qe-yast-refinement)
  • Status changed from New to Workable
Actions #4

Updated by zoecao almost 2 years ago

  • Status changed from Workable to In Progress
  • Assignee set to zoecao
Actions #5

Updated by zoecao almost 2 years ago

Created a pr to fix this ticket, but the github is hard to access today, so will post the PR link here later.
VR for this ticket: https://openqa.suse.de/tests/10090473

Actions #7

Updated by JERiveraMoya almost 2 years ago

  • Parent task set to #121876
Actions #8

Updated by zoecao almost 2 years ago

  • Status changed from In Progress to Resolved

PR is merged, so close here, thanks.

Actions

Also available in: Atom PDF