Project

General

Profile

action #117118

coordination #96596: [qe-core][CI] CI/CD and Coding style improvements

[qe-core] CI/CD and Coding style improvements - Forbid usage of fgrep and egrep

Added by szarate 2 months ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Refactor/Code Improvements
Target version:
Start date:
2022-09-23
Due date:
% Done:

0%

Estimated time:
Difficulty:

Description

As a follow up to https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15547

Since we're having multiple styles of coding and tools, often we end up with a mix, and in the case of grep, it seems that the time for unification has arrived:

fgrep and egrep are now deprecated, so to avoid warnings, we should switch to using extended mode,

Acceptance criteria

  1. Style checks t/01_style.t also verify that neither egrep nor fgrep are being used.
  2. RFC to CONTRIBUTING.md with the above rule in has been created (Or merged in case os-autoinst-distri-opensuse#15547 has been already merged)

Suggestions

Evaluate how #96675 was done

History

#1 Updated by szarate 2 months ago

  • Tracker changed from coordination to action

#2 Updated by szarate 2 months ago

  • Description updated (diff)

#3 Updated by szarate about 2 months ago

  • Sprint set to QE-Core: October Sprint (Sep 28 - Oct 26)
  • Tags set to qe-core-october-sprint
  • Description updated (diff)
  • Category changed from New test to Refactor/Code Improvements
  • Status changed from New to Workable
  • Target version set to QE-Core: Ready

#4 Updated by VANASTASIADIS about 2 months ago

  • Assignee set to VANASTASIADIS

#5 Updated by VANASTASIADIS about 1 month ago

  • Status changed from Workable to Blocked

pr ready: https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/15704

waiting for the related pr to be merged first, as the opposite would lead to the ci failing.

#6 Updated by VANASTASIADIS about 1 month ago

  • Status changed from Blocked to Resolved

Also available in: Atom PDF